-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSJet update for fastjet-contrib 1.044 #30590
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30590/16840
|
A new Pull Request was created by @intrepid42 (Markus Seidel) for master. It involves the following packages: RecoJets/JetProducers @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
please test |
The tests are being triggered in jenkins.
|
-1 Tested at: 9556525 CMSSW: CMSSW_11_2_X_2020-07-07-1100 I found follow errors while testing this PR Failed tests: UnitTests RelVals
I found errors in the following unit tests: ---> test test-rivet-run had ERRORS
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step5_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
the error in 25202.0 step5 is
not quite obviously, but seems related to the externals added in the test |
@cmsbuild please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Update of fastjet-contrib required by new Rivet plugins, see cms-sw/cmsdist#6028
Adapt for small change of
ConstituentSubtractor::set_do_mass_subtraction()
to
Needs to be tested with cms-sw/cmsdist#6028