Update to Rivet 3.1.2 and Yoda 1.8.3

[mseidel42]

Contains a couple of new features and analyses.

Hopefully no interface changes needed. Otherwise, unit tests should fail.

[cmsbuild]

A new Pull Request was created by @intrepid42 (Markus Seidel) for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-02-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7648/console Started: 2020/07/03 13:39

[cmsbuild]

-1

Tested at: 0d6679d

• Build:

I found compilation error when building:

Hunk #2 succeeded at 227 (offset 27 lines).
1 out of 2 hunks FAILED -- saving rejects to file include/Rivet/AnalysisHandler.hh.rej
patching file src/Core/AnalysisHandler.cc
Hunk #1 succeeded at 69 (offset 7 lines).
Hunk #2 succeeded at 79 (offset 7 lines).
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.lMXCgq (%prep)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.lMXCgq (%prep)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ccd3e1/7648/summary.html

[mrodozov]

the patch needs adjustment :/

[cmsbuild]

Pull request #6028 was updated.

[mseidel42]

Done!

(It worked locally with fuzz=1, and then I recreated the patch to work with fuzz=0)

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-03-1200/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7671/console Started: 2020/07/03 19:25

[cmsbuild]

-1

Tested at: 70a7db6

• Build:

I found compilation error when building:

make[2]: Leaving directory `/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/rivet/3.1.2-ccd3e1/rivet-3.1.2/analyses'
make[2]: Leaving directory `/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/rivet/3.1.2-ccd3e1/rivet-3.1.2/analyses'
make[2]: Leaving directory `/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/rivet/3.1.2-ccd3e1/rivet-3.1.2/analyses'
make[1]: Leaving directory `/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/rivet/3.1.2-ccd3e1/rivet-3.1.2/analyses'
make: *** [all-recursive] Error 1
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.04fHex (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.04fHex (%build)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ccd3e1/7671/summary.html

[mseidel42]

Hi all, it turns out that this needs an update of fastjet-contrib to include the LundPlane plugin:

pluginATLAS/ATLAS_2020_I1790256.cc:9:10: fatal error: fastjet/contrib/LundGenerator.hh: No such file or directory
 #include "fastjet/contrib/LundGenerator.hh"

@smuzaffar @fabiocos I see you were the last ones to update fast-jet contrib. Would it be possible to go to the latest 1.044 there?

[mrodozov]

I'll do it

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#30590

• CMSSW_11_2_X_2020-07-08-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7823/console Started: 2020/07/09 14:46

[cmsbuild]

+1
Tested at: 3b61f22
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1c76e/7823/summary.html
CMSSW: CMSSW_11_2_X_2020-07-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1c76e/7823/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2787364
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2787313
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 154 log files, 17 edm output root files, 37 DQM output files

[silviodonato]

@smuzaffar, @mrodozov, @tulamor cms-sw/cmssw#30590 is ready. Can we merge this PR?

[mrodozov]

yes, please :)

[mrodozov]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[makortel]

Could this Rivet update be causing many failures in the NANO step along

Rivet.Analysis.HiggsTemplateCrossSections: WARN  Unkown Higgs production mechanism. Cannot classify event. Classification for all events will most likely fail.
Rivet.AnalysisHandler: INFO  Using named weights
Error in RivetAnalysis::init method: No projections registered for parent 0x2b0f50c7a600
----- Begin Fatal Exception 20-Jul-2020 05:16:37 CEST-----------------------
An exception of category 'FileReadError' occurred while
   [0] Rethrowing an exception that happened on a different thread.
   [1] Reading branch edmTriggerResults_TriggerResults__HLT.
   Additional Info:
      [a] Fatal Root Error: @SUB=TStorageFactoryFile::ReadBufferAsync
Cannot read from a file that is not open

----- End Fatal Exception -------------------------------------------------

? (followed up in cms-sw/cmssw#30836)