-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "Update to Rivet 3.1.2 and Yoda 1.8.3"" #6209
Conversation
This reverts commit 7e19969.
A new Pull Request was created by @intrepid42 (Markus Seidel) for branch IB/CMSSW_11_2_X/master. @cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins.
|
-1 Tested at: da5b6cd CMSSW: CMSSW_11_2_X_2020-09-02-2300 I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-02-2300/src/RecoJets/JetProducers/plugins/CompoundJetProducer.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-02-2300/src/RecoJets/JetProducers/plugins/ECFAdder.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-02-2300/src/RecoJets/JetProducers/plugins/FastjetJetProducer.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-02-2300/src/RecoJets/JetProducers/plugins/FixedGridRhoProducer.cc /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-02-2300/src/RecoJets/JetProducers/plugins/CSJetProducer.cc: In member function 'virtual void cms::CSJetProducer::runAlgorithm(edm::Event&, const edm::EventSetup&)': /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-02-2300/src/RecoJets/JetProducers/plugins/CSJetProducer.cc:149:44: error: no matching function for call to 'fastjet::contrib::ConstituentSubtractor::set_do_mass_subtraction(bool)' subtractor.set_do_mass_subtraction(true); ^ In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-02-2300/src/RecoJets/JetProducers/plugins/CSJetProducer.cc:11: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/fastjet-contrib/1.044-1c9530/include/fastjet/contrib/ConstituentSubtractor.hh:185:10: note: candidate: 'void fastjet::contrib::ConstituentSubtractor::set_do_mass_subtraction()' void set_do_mass_subtraction(); |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
Ah, we need to revert this one again: cms-sw/cmssw#30838 |
Needs cms-sw/cmssw#31355 |
please test with cms-sw/cmssw#31355 |
The tests are being triggered in jenkins.
|
+1 |
Comparison is ready Comparison Summary:
|
please test with cms-sw/cmssw#31355 |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+operations |
+1 |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will be automatically merged. |
Reverts #6103
Multi-stream problems fixed in cms-sw/cmssw#30888