Fix to enable hpsPFTauDiscriminationByDeadECALElectronRejection in run2 reminiAODs

[mbluj]

PR description:

Changes to fix the master/11_2_X-related part of #31015 issue:

• Rerun the anti-electron-in-deadECal tauID with any of run2_miniAOD_80XLegacy, run2_miniAOD_94XFall17, run2_miniAOD_UL re-miniAOD modifiers to enable desired behaviour with leading track extrapolation to the ECal surface.

Introduced changes are expected to:

• not change output when run for non-reminiAOD eras/modifiers,
• modify considered tauID with any of run2_miniAOD_80XLegacy, run2_miniAOD_94XFall17, run2_miniAOD_UL re-miniAOD modifers.

PR validation:

runTheMatrix.py -l limited -i all successful

Checks with custom configurations for miniAOD production (with cmsDriver) that setups with considered modifiers are as expected.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31047/17548

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): Switch to heavy-ion jets in HI miniAOD #30898

[cmsbuild]

A new Pull Request was created by @mbluj for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-04-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8562/console Started: 2020/08/04 18:14

[cmsbuild]

+1
Tested at: 7a81e2c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4d805/8562/summary.html
CMSSW: CMSSW_11_2_X_2020-08-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4d805/8562/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 256 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2525448
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2525394
• DQMHistoTests: Total skipped: 47
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 144 log files, 17 edm output root files, 34 DQM output files

[santocch]

+1

[cmsbuild]

The code-checks are being triggered in jenkins.

[mbluj]

PR updated, its description adjusted.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31047/17643

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): Switch to heavy-ion jets in HI miniAOD #30898

[cmsbuild]

Pull request #31047 was updated. @perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-07-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8661/console Started: 2020/08/07 22:59

[cmsbuild]

+1
Tested at: 16c5230
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4d805/8661/summary.html
CMSSW: CMSSW_11_2_X_2020-08-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4d805/8661/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2612401
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2612346
• DQMHistoTests: Total skipped: 48
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[slava77]

+1

for #31047 16c5230

• code changes are in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show differences only in the slimmedTaus in tauID values corresponding to the deadECAL discriminant; as expected, the difference appears in the re-miniAOD workflow for 2017.
  • manual check of the jenkins outputs shows that re-miniAOD 2018 workflow also has event-by event differences in againstElectronDeadECAL (which apparently cancel out in the histogram of this boolean variable).

[slava77]

@silviodonato @qliphy
this is missing just the analysis signature.
May I suggest to bypass it here.
Thank you.

[qliphy]

+1

[santocch]

+1