Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable hpsPFTauDiscriminationByDeadECALElectronRejection in run2 reminiAODs #31015

Closed
slava77 opened this issue Jul 31, 2020 · 5 comments
Closed

Comments

@slava77
Copy link
Contributor

slava77 commented Jul 31, 2020

(almost) copy from https://github.com/cms-sw/cmssw/pull/29739/files#r463875207

After debugging the discrepancy for UL re-miniAOD in 106X and master, it seems to me that this new module name added in 106X in #29739 is not an optimal solution.

  • in 10_6_X it's a bit semantic (the final result is as expected)
  • in the master branch we apparently have a wrong behavior: the 94X and UL reminiAODs are silently picking up hpsPFTauDiscriminationByDeadECALElectronRejection from the input file

I think that the more appropriate solution would be to

  • in 106X:
    • remove hpsPFTauDiscriminationByDeadECALElectronRejectionForMiniAOD in 106X
    • add run2_miniAOD_devel.toModify(hpsPFTauDiscriminationByDeadECALElectronRejection, extrapolateToECalEntrance = True) in RecoTauTag/Configuration/python/HPSPFTaus_cff.py
    • keep injection of the regular hpsPFTauDiscriminationByDeadECALElectronRejection in the makePatTausTask
  • in the master
    • inject hpsPFTauDiscriminationByDeadECALElectronRejection in the makePatTausTask for run2_miniAOD_UL and run2_miniAOD_94XFall17

@swozniewski @mbluj

@slava77
Copy link
Contributor Author

slava77 commented Jul 31, 2020

assign reconstruction

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction

@slava77,@perrotta,@jpata you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Issue was created by @slava77 Slava Krutelyov.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Aug 21, 2020

+1

resolved via #31047 (merged Aug 17)

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants