Add the anti-electron-in-deadECal tauID to NanoAOD

[mbluj]

PR description:

This PR adds the anti-electron-in-deadECal tauID to NanoAOD which is added to MiniAOD in #29627. This is to follow a new policy that fixes of NanoAOD are added directly to cms-sw master.

Expected changes: the anti-electron-in-deadECal tauID appears in NanoAOD as Tau_idAntiEleDeadECal (bool) branch.

PR validation:

Checked with cmsDriver-generated NanoAOD configurations that expected changes in NanoAOD configuration behave as expected for different tested eras.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31077/17601

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Enabling re-application of Type1 Corrections for PuppiMET and adding PUPPI MET Uncertainties #30922
  • File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): Switch to heavy-ion jets in HI miniAOD #30898, Fix to enable hpsPFTauDiscriminationByDeadECALElectronRejection in run2 reminiAODs #31047

[cmsbuild]

A new Pull Request was created by @mbluj for master.

It involves the following packages:

PhysicsTools/NanoAOD
PhysicsTools/PatAlgos

@perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-06-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8620/console Started: 2020/08/06 17:41

[slava77]

This PR is built on top of not-yet-merged #31047 and thus changes related to it are also displayed here.

I have a mild preference for decoupling this.
IIUC, there is no requirement to have both together, the update in miniAOD_tools is only to get the right kind of againstElectronDeadECAL, which is already available in the processed data, while the update in the nano is to include the ID.

[mbluj]

This PR is built on top of not-yet-merged #31047 and thus changes related to it are also displayed here.

I have a mild preference for decoupling this.
IIUC, there is no requirement to have both together, the update in miniAOD_tools is only to get the right kind of againstElectronDeadECAL, which is already available in the processed data, while the update in the nano is to include the ID.

OK fine. I will overwrite my development branch by one without commits related to #31047. I think tests can be stopped until this PR is updated

[cmsbuild]

The code-checks are being triggered in jenkins.

[mbluj]

Recent commit removes the anti-e in deadECal discriminant from tauTable for run2_nanoAOD_80XLegacy which fixes recent test failures. The discriminant have to be removed for the run2_nanoAOD_80XLegacy era (for rather old samples) as tauIDs are not rerun at all for this era.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31077/17697

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Add ParticleNet to NanoAOD #31096, Enabling re-application of Type1 Corrections for PuppiMET and adding PUPPI MET Uncertainties #30922

[cmsbuild]

Pull request #31077 was updated. @gouskos, @cmsbuild, @fgolf, @mariadalfonso, @santocch, @peruzzim can you please check and sign again.

[mariadalfonso]

please test workflow 1325.6,1325.7,1325.8,1329.1,136.7722,136.7952,136.8521

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 1325.7,1325.6,136.8521,1325.8,136.7722,1329.1,136.7952
• CMSSW_11_2_X_2020-08-11-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8706/console Started: 2020/08/11 17:10

[cmsbuild]

+1
Tested at: 5374da2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2fd267/8706/summary.html
CMSSW: CMSSW_11_2_X_2020-08-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2fd267/8706/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 68 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2612401
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2612352
• DQMHistoTests: Total skipped: 48
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.116 KiB( 34 files compared)
• DQMHistoSizes: changed ( 1325.7 ): 0.116 KiB Physics/NanoAODDQM
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[mariadalfonso]

+xpog
new variable added in nano
will available also for existing miniAOD for both EOY and UL

[slava77]

@silviodonato @qliphy
this is missing just the analysis signature (not a hard requirement these days).
May I suggest to bypass it here.
Thank you.

[qliphy]

+1

[santocch]

+1