Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 'drop*' as not necessary for MicroEventContent (MiniAOD) #30576

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Jul 7, 2020

PR description:

It is unclear the benefit to have
'drop *',
in the definition of MicroEventContent. This drop will happen anyways in e.g.
https://github.com/cms-sw/cmssw/blob/master/Configuration/EventContent/python/EventContent_cff.py#L783-L788

With this drop in the definition of MicroEventContent, it will make a bit more longer cmsDriver if we would like to add MiniAOD together with anything, e.g. RECO + MiniAOD together for TDR study.

PR validation:

cmsDriver.py step1 --conditions auto:phase2_realistic_T15 -n 2 --era Phase2C9 --eventcontent RECOSIM,MINIAODSIM,DQM --runUnscheduled --filein /store/relval/CMSSW_11_0_0/RelValTTbar_14TeV/GEN-SIM-DIGI-RAW/PU25ns_110X_mcRun4_realistic_v3_2026D49PU200-v2/10000/01054EE2-1B51-C449-91A2-5202A60D16A3.root -s RAW2DIGI,L1TrackTrigger,L1,RECO,RECOSIM,PAT,VALIDATION:@phase2Validation+@miniAODValidation,DQM:@phase2+@miniAODDQM --datatier GEN-SIM-RECO,MINIAODSIM,DQMIO --customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_1000,L1Trigger/Configuration/customisePhase2TTNoMC.customisePhase2TTNoMC --geometry Extended2026D49 --fileout file:step1_WithValidation.root --customise_command "process.RECOSIMoutput.outputCommands.append('keep *_*_*_HLT'); process.RECOSIMoutput.outputCommands.append('keep *_*_*_SIM'); process.RECOSIMoutput.outputCommands.extend(process.L1TriggerFEVTDEBUG.outputCommands); process.RECOSIMoutput.outputCommands.extend(process.MicroEventContentMC.outputCommands)" --no_exec --python RECO_WithValidation.py

Without: Only MINIAOD content will be written as RECOSIM
With this PR: MINIAOD content is added together with RECOSIM and L1T

if this PR is a backport please specify the original PR and why you need to backport that PR:

The backport will need for 11_1 (if we decide to use for HLTTDR production)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30576/16811

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jul 7, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

+1
Tested at: 87c53ad
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe177c/7756/summary.html
CMSSW: CMSSW_11_2_X_2020-07-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe177c/7756/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787364
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2787307
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Jul 7, 2020

+1

  • Technical: "drop" indeed not nevessary
  • Jenkins tests pass

@silviodonato
Copy link
Contributor

merge

1 similar comment
@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 5ade261 into cms-sw:master Jul 9, 2020
@santocch
Copy link

santocch commented Jul 9, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants