Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pixel Tracks in Heavy Ions MiniAOD #30313

Merged

Conversation

CesarBernardes
Copy link
Contributor

Dear All,

this PR is made to include Pixel Tracks (dedicated to low-pT tracks 0.3-1.0GeV/c) to Heavy Ions MIniAOD content. So, this is expected to be included only for the eras "pp_on_AA_2018" and "pp_on_PbPb_run3". It includes an EDProducer to create a "packed pixel tracks collection" (similar to "lostTracks" collection) using as input "hiConformalPixelTracks". The studies below was made in 103X, but in 112X we also did the test "runTheMatrix.py -l limited -i all --ibeos", in special workflow 159 that uses these commits.

https://www.dropbox.com/s/sl08rl1xw8a27xi/slides_MiniAOD_PixelTracks_v2.pdf?dl=0

The slides above show some description and comparison of the input collection vs new collection. The quality variables in slide 6 are expected to not match, since we used a less accurate covariance schema to save space. In addition, we added a pt cut of pt<1GeV/c, since in HI analyses using pixel tracks we only consider this pT range.

@mandrenguyen @abaty

Best Regards

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30313/16283

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30313/16296

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @CesarBernardes (Cesar Bernardes) for master.

It involves the following packages:

PhysicsTools/PatAlgos
RecoHI/HiTracking

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @schoef, @emilbols, @echapon, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @dgulhan, @jdolen, @ferencek, @mandrenguyen, @yetkinyilmaz, @jdamgov, @nhanvtran, @gkasieczka, @hatakeyamak, @mariadalfonso, @clelange, @riga, @jazzitup, @JyothsnaKomaragiri, @mverzett, @yenjie, @kurtejung, @gpetruc, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jun 20, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 20, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: c3600fb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f6ba2/7221/summary.html
CMSSW: CMSSW_11_2_X_2020-06-20-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30313/16820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Pull request #30313 was updated. @perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Jul 7, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

+1
Tested at: eaafc66
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f6ba2/7769/summary.html
CMSSW: CMSSW_11_2_X_2020-07-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f6ba2/7769/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787364
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2787313
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jul 7, 2020

+1

for #30313 eaafc66

  • code changes are in line with the PR description and the follow up review
  • jenkins tests pass and comparisons with the baseline show differences only in wf 158.01 running HI miniAOD: hiPixelTracks collection appears in the outputs, no other differences are found.
  • local test with 1K events of wf 140.5611 (HI 2018 data re-miniAOD) shows that the new module hiPixelTracks takes about 15 ms/event (0.3% of miniAOD process) and the output MINIAOD file increases by about 13% or 18.4 KiB (from an average of 1390 hiPixelTracks per event; about 13.3 bytes/candidate)

@santocch
Copy link

santocch commented Jul 9, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0526ff2 into cms-sw:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants