Addition of packedCandidates track chi2 information to pp_on_AA miniAOD

[abaty]

PR description:

This add a producer that makes two value maps which store the normalized-chi2 values of the tracks attached to objects in the PackedPFCandidate and lostTracks collections for mini-AOD in the pp_on_AA eras. These normalized chi2 values are used in many heavy ion analyses as part of the track selection.

PR validation:

This was checked using the config in /afs/cern.ch/user/a/abaty/work/public/forPeople/forChi2PR, which was used for testing the heavy ion miniAOD workflow. Both new collections (for lostTracks and PackedPFCandidates) are present and contain reasonable values.

@mandrenguyen

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30566/16803

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py modified in PR(s): [RFC] Store TrackExtra, TrackingRecHits, and SiPixel/StripClusters for muons in AOD+MINIAOD #30544, Add Pixel Tracks in Heavy Ions MiniAOD #30313
  • File PhysicsTools/PatAlgos/python/slimming/slimming_cff.py modified in PR(s): [RFC] Store TrackExtra, TrackingRecHits, and SiPixel/StripClusters for muons in AOD+MINIAOD #30544, Add Pixel Tracks in Heavy Ions MiniAOD #30313

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30566/16803/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30566/16803/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[slava77]

uint8_t normalizedChi2_ is saved in the packed cands. Is this too coarse?

[abaty]

uint8_t normalizedChi2_ is saved in the packed cands. Is this too coarse?

Yes, we found that this variable is not precise enough for our needs because it is truncated to a uint8.

[slava77]

Code check has found code style and quality issues which could be resolved by applying following patch(s)

* **code-format**:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30566/16803/code-format.patch

this is required before further tests of this PR can be done

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30566/16856

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py modified in PR(s): [RFC] Store TrackExtra, TrackingRecHits, and SiPixel/StripClusters for muons in AOD+MINIAOD #30544, Add Pixel Tracks in Heavy Ions MiniAOD #30313, Drop 'drop*' as not necessary for MicroEventContent (MiniAOD) #30576
  • File PhysicsTools/PatAlgos/python/slimming/slimming_cff.py modified in PR(s): [RFC] Store TrackExtra, TrackingRecHits, and SiPixel/StripClusters for muons in AOD+MINIAOD #30544, Add Pixel Tracks in Heavy Ions MiniAOD #30313

[cmsbuild]

A new Pull Request was created by @abaty for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-07-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7787/console Started: 2020/07/08 19:42

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-17-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8095/console Started: 2020/07/18 04:13

[cmsbuild]

+1
Tested at: 0cf27e8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0e872/8095/summary.html
CMSSW: CMSSW_11_2_X_2020-07-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0e872/8095/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2525996
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2525948
• DQMHistoTests: Total skipped: 47
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 144 log files, 17 edm output root files, 34 DQM output files

[jpata]

+1

(see motivation here: #30566 (comment))

[perrotta]

+1 (see motivation here: #30566 (comment))

@jpata reco approval was added and removed at once by bot. I suspect it is because "+1" and the comment are written on the same line. Maybe you can try with two separate lines and see whether it is accepted as such...

[jpata]

+1 (see motivation here: #30566 (comment))

@jpata reco approval was added and removed at once by bot. I suspect it is because "+1" and the comment are written on the same line. Maybe you can try with two separate lines and see whether it is accepted as such...

Oops, thanks for the heads up.

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1