fix direct access to tau ID container

[swozniewski]

PR description:

This PR fixes the index mapping for direct access to tau ID containers. The functionality is only for private use and test purposes and does not concern existing workflows.
The fixed lines can be compared to the regular workflows some lines above, which are using provenance, e.g. https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/PatAlgos/plugins/PATTauProducer.cc#L405-L409 and are supposed to follow the same logic of the internal index mapping.

PR validation:

compiles, no further checks run due to simplicity of changes

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30106/15864

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/PatAlgos/plugins/PATTauProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
  • File Validation/RecoTau/src/TauTagValidation.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-emplace #29937

[cmsbuild]

A new Pull Request was created by @swozniewski for master.

It involves the following packages:

PhysicsTools/PatAlgos
Validation/RecoTau

@perrotta, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU, @slava77, @santocch can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6803/console Started: 2020/06/04 13:18

[cmsbuild]

+1
Tested at: 723af99
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4954c9/6803/summary.html
CMSSW: CMSSW_11_2_X_2020-06-03-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Allow running PUPPI v14 customizer on data #30017 @ahinzmann: Allow running PUPPI v14 customizer on data
• [DD4HEP] common and muon alignment DD4HEP migration #29952 @hyunyong: [DD4HEP] common and muon alignment DD4HEP migration
• Move DT calibration DQM modules back to Sequence #30076 @makortel: Move DT calibration DQM modules back to Sequence
• Add GEM to MuonRecoAnalyzer #30096 @seungjin-yang: Add GEM to MuonRecoAnalyzer
• [Tracker Alignment] Split vertex resolution validation submitter #30091 @mmusich: [Tracker Alignment] Split vertex resolution validation submitter
• Move SiStrip calibration DQM modules back to Sequence #30083 @makortel: Move SiStrip calibration DQM modules back to Sequence
• Add a plugin that can depend on any product #30101 @fwyzard: Add a plugin that can depend on any product
• fix cmssw patch version for non-standard IBs e.g ROOT6, DEVEL #30092 @smuzaffar: fix cmssw patch version for non-standard IBs e.g ROOT6, DEVEL

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4954c9/6803/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4954c9/6803/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4954c9/6803/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2783946
• DQMHistoTests: Total failures: 116948
• DQMHistoTests: Total nulls: 2
• DQMHistoTests: Total successes: 2666946
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 2.095 KiB( 35 files compared)
• DQMHistoSizes: changed ( 1000.0 ): 0.039 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 1000.0 ): 0.039 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 11634.0,... ): 0.080 KiB Muons_miniAOD/MuonRecoAnalyzer
• DQMHistoSizes: changed ( 11634.0,... ): 0.072 KiB Muons/MuonRecoAnalyzer
• DQMHistoSizes: changed ( 136.731,... ): 0.023 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 136.731,... ): 0.023 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 140.56,... ): 0.016 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 140.56,... ): 0.016 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 20034.0,... ): 0.143 KiB Muons_miniAOD/MuonRecoAnalyzer
• DQMHistoSizes: changed ( 20034.0,... ): 0.135 KiB Muons/MuonRecoAnalyzer
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[jfernan2]

please test
Triggering the test agian to decouple from external merge commits included above

[cmsbuild]

+1
Tested at: 723af99
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4954c9/6818/summary.html
CMSSW: CMSSW_11_2_X_2020-06-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4954c9/6818/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2783960
• DQMHistoTests: Total failures: 25
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2783885
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[jfernan2]

+1
No changes

[slava77]

type bugfix

[slava77]

+1

for #30106 723af99

• code changes are in line with the PR description
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[silviodonato]

+1

[silviodonato]

merge
cc: @santocch

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.