-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cmssw patch version for non-standard IBs e.g ROOT6, DEVEL #30092
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30092/15832
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages: RecoTauTag/RecoTau @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This fixes the unit test failure (added by #29976 ) in non-standard IBs (e.g DEVEL, ROOT6 etc). Code here https://github.com/cms-tau-pog/cmssw/blob/7aaf1ab52d1f044b47e43ce446576a726fb2970e/RecoTauTag/RecoTau/python/tools/runTauIdMVA.py#L70 Assumes that that patch version of cmssw is either
X
or a number but for non-standard IBs it could beROOT6
,DEVEL
etc. The change proposed here should fix this.PR validation:
Build and successfully run unit test locally for both standard and non-standard IBs.