Move DT calibration DQM modules back to Sequence

[makortel]

PR description:

This PR is a follow-up to #29630 and reverts the changes made to DT calibration DQM modules by moving them back to Sequences, i.e. to be run only if the preceding filters keep processing the event.

PR validation:

Limited matrix runs, expecting changes in DT AlcaReco DQM plots.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30076/15804

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

CalibMuon/DTCalibration
DQM/DTMonitorModule

@andrius-k, @kmaeshima, @christopheralanwest, @schneiml, @tocheng, @cmsbuild, @jfernan2, @fioriNTU, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6736/console Started: 2020/06/02 15:12

[cmsbuild]

+1
Tested at: ea6b129
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b58020/6736/summary.html
CMSSW: CMSSW_11_2_X_2020-06-01-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b58020/6736/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2783666
• DQMHistoTests: Total failures: 1219
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2782396
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.062 KiB( 35 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): 0.016 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 1000.0,... ): 0.016 KiB MessageLogger/Errors
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[jfernan2]

+1

[makortel]

This PR in fact also fixes the failure in 1004.0 in IBs

An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 182124 lumi: 40 event: 1893722 stream: 3
   [1] Calling method for module DTLocalTriggerSynchTask/'dtTriggerSynchMonitor'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::RangeMap<DTChamberId,edm::OwnVector<DTRecSegment4D,edm::ClonePolicy<DTRecSegment4D> >,edm::ClonePolicy<DTRecSegment4D> >
Looking for module label: dt4DSegmentsNoWire
Looking for productInstanceName: 

https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc820/CMSSW_11_2_X_2020-06-01-2300/pyRelValMatrixLogs/run/1004.0_RunHI2011+RunHI2011+TIER0EXPHI+ALCAEXPHI+ALCAHARVD1HI+ALCAHARVD2HI+ALCAHARVD3HI+ALCAHARVD5HI/step2_RunHI2011+RunHI2011+TIER0EXPHI+ALCAEXPHI+ALCAHARVD1HI+ALCAHARVD2HI+ALCAHARVD3HI+ALCAHARVD5HI.log#/

[makortel]

urgent

[makortel]

@cmsbuild, please test workflow 1004.0

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 1004.0
  https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6772/console Started: 2020/06/03 15:58

[cmsbuild]

+1
Tested at: ea6b129
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b58020/6772/summary.html
CMSSW: CMSSW_11_2_X_2020-06-02-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b58020/6772/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b58020/1004.0_RunHI2011+RunHI2011+TIER0EXPHI+ALCAEXPHI+ALCAHARVD1HI+ALCAHARVD2HI+ALCAHARVD3HI+ALCAHARVD5HI

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2783666
• DQMHistoTests: Total failures: 1173
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2782442
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.062 KiB( 35 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): 0.016 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 1000.0,... ): 0.016 KiB MessageLogger/Errors
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[pohsun]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1