Apply code checks to the OnlineDB packages

[fwyzard]

Apply clang-tidy automated code changes.
Apply clang-format automated code formatting.

[cmsbuild]

The code-checks are being triggered in jenkins.

[fwyzard]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29891/15462

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File OnlineDB/EcalCondDB/bin/cmsecal_rootplot.cpp modified in PR(s): Enable additional code checks (effect of #29858) #29863

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6379/console Started: 2020/05/18 13:38

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

OnlineDB/EcalCondDB

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@rchatter, @mmusich, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: ae20c37
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-69ae27/6379/summary.html
CMSSW: CMSSW_11_1_X_2020-05-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• EMTF May 2020 emulator update #29767 @jiafulow: EMTF May 2020 emulator update
• Explictly include root's TObjString header to fix the unit test for ROOT6 Ibs #29862 @cms-sw: Explictly include root's TObjString header to fix the unit test for ROOT6 Ibs
• Clean BuildFiles in ALCA #29805 @guitargeek: Clean BuildFiles in ALCA

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-69ae27/6379/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-69ae27/6379/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-69ae27/6379/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2694466
• DQMHistoTests: Total failures: 48
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2694369
• DQMHistoTests: Total skipped: 49
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 150 log files, 16 edm output root files, 35 DQM output files

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[silviodonato]

@fwyzard @cms-sw/core-l2 sorry for the silly question. Why didn't this PR apply the code-format fixes to OnlineDB/EcalCondDB/interface/IRunIOV.h ? From #31322 it looks like these fixes should have been applied d328dc5

[makortel]

Doing

cmsrel CMSSW_11_1_0_pre7 # released May 8th
cd CMSSW_11_1_0_pre7/src
cmsenv
git cms-addpkg OnlineDB/EcalCondDB
clang-format -i OnlineDB/EcalCondDB/interface/*

does change OnlineDB/EcalCondDB/interface/IRunIOV.h as in d328dc5. Just guessing but maybe clang-format didn't get run on that file for some reason?