Cleanups in PhysicsTools and OnlineDB

[davidlange6]

Finish old migration and remove long-ago-moved headers in PhyscisTools
Add virtual destructor to a presumably unused class in OnlineDB.
Both identified as warnings in the modules IB.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31322/18081

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31322/18081/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31322/18081/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31322/18084

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

OnlineDB/EcalCondDB
PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@perrotta, @cmsbuild, @jpata, @slava77, @ggovi, @santocch can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @argiro, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mmusich, @mariadalfonso, @clelange, @rchatter, @riga, @JyothsnaKomaragiri, @gpetruc, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-01-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9052/console Started: 2020/09/02 09:54

[cmsbuild]

+1
Tested at: d328dc5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-653aa9/9052/summary.html
CMSSW: CMSSW_11_2_X_2020-09-01-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-653aa9/9052/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2609633
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[perrotta]

+1

• Technical
• It also include some code-format adjustments
• Jenkins tests pass

[santocch]

+1

[silviodonato]

any objections @cms-sw/db-l2 ?

[silviodonato]

merge
fyi @ggovi