Explictly include root's TObjString header to fix the unit test for ROOT6 Ibs

[smuzaffar]

PR description:

This is needed due to headers cleanup in ROOT6 master branch ( see #29740 ). The unit test fails for root6 master based IBs [a]

[a]

Info in <TUnixSystem::ACLiC>: creating shared library CMSSW_11_1_ROOT6_X_2020-05-15-2300/tmp/PixelBaryCentreTool/PixelBaryCentrePlottingTools/./PlotMillePede
_C.so
In file included from input_line_12:6:
././PlotMillePede.C:410:76: error: unknown type name 'TObjString'
  if (whichOne.Contains("result", TString::kIgnoreCase)) whichOnes.Add(new TObjString("result"));
                                                                           ^
././PlotMillePede.C:411:76: error: unknown type name 'TObjString'
  if (whichOne.Contains("start",  TString::kIgnoreCase)) whichOnes.Add(new TObjString("start"));
                                                                           ^
././PlotMillePede.C:412:76: error: unknown type name 'TObjString'
  if (whichOne.Contains("diff",   TString::kIgnoreCase)) whichOnes.Add(new TObjString("diff"));

[smuzaffar]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29862/15426

• This PR adds an extra 8KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29862/15426/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29862/15426/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29862/15427

• This PR adds an extra 8KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6360/console Started: 2020/05/17 15:03

[cmsbuild]

+1
Tested at: 32d30fd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f04848/6360/summary.html
CMSSW: CMSSW_11_1_X_2020-05-17-0000
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f04848/6360/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2694466
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2694414
• DQMHistoTests: Total skipped: 49
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 150 log files, 16 edm output root files, 35 DQM output files

[pohsun]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1