From cmssw 10 2 21 #29490

chiaraaime · 2020-04-16T09:38:25Z

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

Pog muon loose

Adding a few jet and event variables to prepare for automatic JEC workflows

cmsbuild · 2020-04-16T09:39:20Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-04-16T09:53:42Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29490/14708

This PR adds an extra 784KB to repository
Found files with invalid states:
- GeneratorInterface/GenFilters/plugins/LHEPtFilter.h:
  - Added: a9ddb3d
  - Deleted: b2f8377
- RecoTauTag/RecoTau/interface/MuonHitMatch.h:
  - Added: 2a48d15
  - Deleted: dd6ec80
- FastSimulation/SimplifiedGeometryPropagator/interface/FastTrackDeDxProducer.h:
  - Added: c02eafd
  - Modified: cc1d44a, db26faa, 30ee8b8, 15504f6, 6b71a65, e4f19b8
  - Deleted: 30b5dbc
- GeneratorInterface/GenFilters/interface/LHEPtFilter.h:
  - Added: 36dfe34
  - Deleted: a9ddb3d
- GeneratorInterface/GenFilters/src/TopLHEFilter.cc:
  - Added: 412e613
  - Deleted: 0435ac1
- GeneratorInterface/GenFilters/python/TopLHEFilter_cfi.py:
  - Added: 412e613
  - Deleted: 0435ac1
- GeneratorInterface/GenFilters/plugins/LHEPtFilter.cc:
  - Added: a9ddb3d
  - Modified: b2f8377, 2587c08, 9682a78, 95a65f0, 461162c
  - Deleted: 4de234f
- RecoTauTag/RecoTau/plugins/MuonHitMatch.cc:
  - Added: 2a48d15
  - Deleted: dd6ec80
- GeneratorInterface/GenFilters/src/LHEPtFilter.cc:
  - Added: 36dfe34, 4de234f
  - Deleted: a9ddb3d
There are other open Pull requests which might conflict with changes you have proposed:
- File CommonTools/PileupAlgos/plugins/PuppiProducer.cc modified in PR(s): PUPPI MET in RECO #29254
- File Configuration/AlCa/python/autoCond.py modified in PR(s): pixel mc gain calibration scheme: new GTs for MC Run3, modified Clusterizer conditions for Run3 #29333
- File Configuration/Applications/python/ConfigBuilder.py modified in PR(s): Speed up filesFromList and filesFromDASQuery in ConfigBuilder.py #29454
- File Configuration/StandardSequences/python/Reconstruction_cff.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQM/Integration/python/clients/beampixel_dqm_sourceclient-live_cfg.py modified in PR(s): DQM: Added unit test support for most online DQM clients #29372
- File DQM/Integration/python/clients/ctpps_dqm_sourceclient-live_cfg.py modified in PR(s): DQM: Added unit test support for most online DQM clients #29372
- File DQM/Integration/python/clients/gem_dqm_sourceclient-live_cfg.py modified in PR(s): DQM: Added unit test support for most online DQM clients #29372
- File DQM/Integration/python/clients/hcal_dqm_sourceclient-live_cfg.py modified in PR(s): DQM: Added unit test support for most online DQM clients #29372
- File DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py modified in PR(s): DQM: Added unit test support for most online DQM clients #29372
- File DQM/Integration/python/clients/l1tstage2emulator_dqm_sourceclient-live_cfg.py modified in PR(s): DQM: Added unit test support for most online DQM clients #29372
- File DQM/TrackingMonitor/interface/TrackAnalyzer.h modified in PR(s): TRK DQM : add dz and dzErr profiles #29455
- File DQM/TrackingMonitor/python/TrackingMonitor_cfi.py modified in PR(s): TRK DQM : add dz and dzErr profiles #29455
- File DQM/TrackingMonitor/src/TrackAnalyzer.cc modified in PR(s): TRK DQM : add dz and dzErr profiles #29455
- File DataFormats/L1TMuon/interface/EMTFHit.h modified in PR(s): EMTF March 2020 emulator update #29262
- File DataFormats/L1TMuon/src/EMTFHit.cc modified in PR(s): EMTF March 2020 emulator update #29262
- File DataFormats/PatCandidates/src/classes_def_objects.xml modified in PR(s): PUPPI MET in RECO #29254
- File EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockRPC.cc modified in PR(s): EMTF March 2020 emulator update #29262
- File EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockSP.cc modified in PR(s): EMTF March 2020 emulator update #29262
- File EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFUnpackerTools.cc modified in PR(s): EMTF March 2020 emulator update #29262
- File EventFilter/SiPixelRawToDigi/plugins/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File IOPool/Input/src/RootPrimaryFileSequence.cc modified in PR(s): New developments using multiple data catalogs provided in site-local-config.xml #28911
- File IOPool/Input/src/RootPrimaryFileSequence.h modified in PR(s): New developments using multiple data catalogs provided in site-local-config.xml #28911
- File IOPool/Input/src/RootSecondaryFileSequence.cc modified in PR(s): New developments using multiple data catalogs provided in site-local-config.xml #28911
- File IOPool/Input/src/RootSecondaryFileSequence.h modified in PR(s): New developments using multiple data catalogs provided in site-local-config.xml #28911
- File L1Trigger/L1TMuon/interface/MuonTriggerPrimitive.h modified in PR(s): EMTF March 2020 emulator update #29262
- File L1Trigger/L1TMuon/src/MuonTriggerPrimitive.cc modified in PR(s): EMTF March 2020 emulator update #29262
- File L1Trigger/L1TMuonEndCap/interface/Common.h modified in PR(s): EMTF March 2020 emulator update #29262
- File L1Trigger/L1TMuonEndCap/interface/EMTFSubsystemTag.h modified in PR(s): EMTF March 2020 emulator update #29262
- File L1Trigger/L1TMuonEndCap/interface/PrimitiveConversion.h modified in PR(s): EMTF March 2020 emulator update #29262
- File L1Trigger/L1TMuonEndCap/interface/SectorProcessor.h modified in PR(s): EMTF March 2020 emulator update #29262
- File L1Trigger/L1TMuonEndCap/interface/TrackFinder.h modified in PR(s): EMTF March 2020 emulator update #29262
- File L1Trigger/L1TMuonEndCap/plugins/L1TMuonEndCapTrackProducer.cc modified in PR(s): EMTF March 2020 emulator update #29262
- File L1Trigger/L1TMuonEndCap/python/simEmtfDigis_cfi.py modified in PR(s): EMTF March 2020 emulator update #29262
- File L1Trigger/L1TMuonEndCap/src/EMTFSubsystemCollector.cc modified in PR(s): EMTF March 2020 emulator update #29262
- File L1Trigger/L1TMuonEndCap/src/PrimitiveConversion.cc modified in PR(s): EMTF March 2020 emulator update #29262
- File L1Trigger/L1TMuonEndCap/src/PrimitiveSelection.cc modified in PR(s): EMTF March 2020 emulator update #29262
- File L1Trigger/L1TMuonEndCap/src/TrackFinder.cc modified in PR(s): EMTF March 2020 emulator update #29262
- File PhysicsTools/PatAlgos/plugins/PATPackedCandidateProducer.cc modified in PR(s): PUPPI MET in RECO #29254
- File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): PUPPI MET in RECO #29254
- File PhysicsTools/PatAlgos/python/tools/jetTools.py modified in PR(s): PUPPI MET in RECO #29254, Restore TF and MXNet-based inference for DeepJet, DeepDoubleX and DeepAK8 #29172
- File PhysicsTools/PatUtils/python/tools/runMETCorrectionsAndUncertainties.py modified in PR(s): PUPPI MET in RECO #29254
- File RecoBTag/TensorFlow/BuildFile.xml modified in PR(s): Restore TF and MXNet-based inference for DeepJet, DeepDoubleX and DeepAK8 #29172
- File RecoBTag/TensorFlow/interface/tensor_fillers.h modified in PR(s): Restore TF and MXNet-based inference for DeepJet, DeepDoubleX and DeepAK8 #29172
- File RecoBTag/TensorFlow/plugins/BuildFile.xml modified in PR(s): Restore TF and MXNet-based inference for DeepJet, DeepDoubleX and DeepAK8 #29172
- File RecoBTag/TensorFlow/plugins/DeepDoubleXTFJetTagsProducer.cc modified in PR(s): Restore TF and MXNet-based inference for DeepJet, DeepDoubleX and DeepAK8 #29172
- File RecoBTag/TensorFlow/src/tensor_fillers.cc modified in PR(s): Restore TF and MXNet-based inference for DeepJet, DeepDoubleX and DeepAK8 #29172
- File RecoEgamma/Configuration/python/RecoEgamma_EventContent_cff.py modified in PR(s): Update eventcontent structure and remove drop #29225
- File RecoEgamma/EgammaElectronProducers/plugins/LowPtGSFToTrackLinker.cc modified in PR(s): Removing GEDGsfElectronProducer - No inheriting electron producers anymore #29303
- File RecoEgamma/EgammaElectronProducers/plugins/LowPtGsfElectronSCProducer.cc modified in PR(s): Removing GEDGsfElectronProducer - No inheriting electron producers anymore #29303
- File RecoEgamma/EgammaElectronProducers/plugins/LowPtGsfElectronSeedProducer.cc modified in PR(s): Removing GEDGsfElectronProducer - No inheriting electron producers anymore #29303
- File RecoEgamma/EgammaElectronProducers/python/gedGsfElectrons_cfi.py modified in PR(s): Removing GEDGsfElectronProducer - No inheriting electron producers anymore #29303
- File RecoEgamma/EgammaElectronProducers/python/gsfElectrons_cfi.py modified in PR(s): Removing GEDGsfElectronProducer - No inheriting electron producers anymore #29303
- File RecoEgamma/EgammaElectronProducers/python/lowPtGsfElectrons_cfi.py modified in PR(s): Removing GEDGsfElectronProducer - No inheriting electron producers anymore #29303
- File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File RecoMET/METAlgorithms/src/METSignificance.cc modified in PR(s): PUPPI MET in RECO #29254
- File RecoParticleFlow/PFProducer/plugins/PFEGammaProducer.cc modified in PR(s): Don't include forward headers in cc files in RecoParticleFlow/PFProducer package #29410
- File RecoParticleFlow/PFProducer/plugins/PFProducer.cc modified in PR(s): Don't include forward headers in cc files in RecoParticleFlow/PFProducer package #29410, Removing GEDGsfElectronProducer - No inheriting electron producers anymore #29303
- File RecoPixelVertexing/Configuration/python/customizePixelTracksForProfiling.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File SimDataFormats/GeneratorProducts/src/classes.h modified in PR(s): Run GeneratorFilter modules in an external process controlled by cmsRun #29445
- File SimDataFormats/GeneratorProducts/src/classes_def.xml modified in PR(s): Run GeneratorFilter modules in an external process controlled by cmsRun #29445

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29490/14708/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29490/14708/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29490/14708/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29490/14708/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

slava77 · 2020-04-16T13:49:32Z

-1

wrong branch or broken PR

kpedro88 · 2020-04-16T14:28:31Z

-1

peruzzim and others added 30 commits May 14, 2019 23:55

Add jercVars to sequence

31fc86d

Merge pull request cms-sw#360 from sscruz/POG_muon_loose

3f603c6

Pog muon loose

Update nanoDQM_cfi.py

0e48744

genparticle development

68bc2f0

configurable precision per object

42ec408

small bug solving

c08958c

Merge pull request cms-sw#246 from rappoccio/rappoccio_nanoaodjerc_102x

18046ad

Adding a few jet and event variables to prepare for automatic JEC workflows

New STXS Stage 1.1

0755063

running code-checks

557cb91

fixing typo

811d33d

fixing compiling issues

98a7111

Skeleton for DeepTau v2.

46b5b45

motifications for the TauBlockInputs

38b94ba

fixed some issues

14ba37b

Improved CellGrid implementation.

e9d2ab0

changes in the hadronBlock

a34517f

updates in the hadron block

032e839

Fixed some problems with the hadron block

76b0ba5

Continue fixing some problems in the hadron block

7bc364f

Continue fixing some problems in the hadron block

5a2e9f1

Updates in the electron block

143865b

Fix in the GetValue function

6759481

Fixed some indentation problems

592a976

Applied comments

4935eca

applied comments

ef25a0d

Fixed indentation

f1d19e4

improvements into the muon block

2a48d15

Modifications in the muon block

dd6ec80

applied comments

03295bf

Modificacion to add v2 in the python config

d596bc9

cmsbuild added l1-pending new-package-pending operations-pending orp-pending pdmv-pending pending-signatures reconstruction-pending simulation-pending tests-pending upgrade-pending visualization-pending xpog-pending labels Apr 16, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Apr 16, 2020

This was referenced Apr 16, 2020

DQM: Added unit test support for most online DQM clients #29372

Merged

PUPPI MET in RECO #29254

Merged

cmsbuild added reconstruction-rejected and removed reconstruction-pending labels Apr 16, 2020

cmsbuild mentioned this pull request Apr 16, 2020

Decrease begin Run startup time for HLT #29492

Merged

cmsbuild added upgrade-rejected and removed upgrade-pending labels Apr 16, 2020

silviodonato closed this Apr 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

From cmssw 10 2 21 #29490

From cmssw 10 2 21 #29490

chiaraaime commented Apr 16, 2020

cmsbuild commented Apr 16, 2020

cmsbuild commented Apr 16, 2020

slava77 commented Apr 16, 2020

kpedro88 commented Apr 16, 2020

From cmssw 10 2 21 #29490

From cmssw 10 2 21 #29490

Conversation

chiaraaime commented Apr 16, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Apr 16, 2020

cmsbuild commented Apr 16, 2020

slava77 commented Apr 16, 2020

kpedro88 commented Apr 16, 2020