Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRK DQM : add dz and dzErr profiles #29455

Closed
wants to merge 2 commits into from

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Apr 10, 2020

PR description:

while looking at the track-vertex association, it turns out we do not monitor the track dz
in particular its error as function of the track eta

this update introduces new plots to the TRK directories

PR validation:

pass all tests done via runTheMatrix.py -l limited -i all --ibeos

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29455/14645

  • This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@silviodonato
Copy link
Contributor

@mtosi we cannot do anything until you apply the automatic code-format fixes

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29455/14645

* This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

* **code-format**:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29455/14645/code-format.patch
  e.g. `curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29455/14645/code-format.patch | patch -p1`
  You can also run `scram build code-format` to apply code format directly

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mtosi
Copy link
Contributor Author

mtosi commented Apr 17, 2020

@silviodonato thanks for the reminder !

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29455/14755

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for master.

It involves the following packages:

DQM/TrackingMonitor

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5752/console Started: 2020/04/17 14:56

@cmsbuild
Copy link
Contributor

+1
Tested at: 73c31e7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0fcad3/5752/summary.html
CMSSW: CMSSW_11_1_X_2020-04-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0fcad3/5752/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696435
  • DQMHistoTests: Total failures: 37
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696079
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1342.163 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 22.491 KiB Tracking/TrackParameters
  • DQMHistoSizes: changed ( 1000.0 ): 8.396 KiB AlCaReco/TkAlCosmicsInCollisions
  • DQMHistoSizes: changed ( 1000.0 ): 5.539 KiB AlCaReco/TkAlMuonIsolated
  • DQMHistoSizes: changed ( 1000.0 ): 5.521 KiB AlCaReco/TkAlUpsilonMuMu
  • DQMHistoSizes: changed ( 1000.0 ): 5.469 KiB AlCaReco/TkAlJpsiMuMu
  • DQMHistoSizes: changed ( 1000.0,... ): 5.451 KiB AlCaReco/TkAlMinBias
  • DQMHistoSizes: changed ( 1000.0 ): 5.416 KiB AlCaReco/TkAlZMuMu
  • DQMHistoSizes: changed ( 1000.0,... ): 5.166 KiB AlCaReco/SiStripCalMinBias
  • DQMHistoSizes: changed ( 1000.0,... ): 4.894 KiB Muons/globalMuons
  • DQMHistoSizes: changed ( 1000.0,... ): 4.591 KiB Muons/Tracking
  • DQMHistoSizes: changed ( 1000.0 ): ...
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

Ciao @mtosi , I have several quetions:

  • could you please elaborate a bit where the new plots should be added?

  • What is the scope of these new plots? Release validation? Tracking scenarios test? The plots are being addeed in every single workflow but FastSim: data, cosmics, HI, MC, Run1, Run2, Run3, Phase2

  • Have you checked in your tests if the output makes sense beyond a successful runTheMatrix -l ?

  • I see that plots are added not only to the Tracking folder but in many other places like HLT, EGM, Muon, and even EXO, and in many cases empty, instead the Tracking folder has stats.

  • In particular plots dubbed DCASi_inner are always empty for every workflow and every folder, while DistanceOfClosestApproachAlongZ* in the same folder are totally filled with plenty of stats, is this expected?
    Thanks

@silviodonato
Copy link
Contributor

Ciao @mtosi , I have several quetions:

* could you please elaborate a bit where the new plots should be added?

* What is the scope of these new plots? Release validation? Tracking scenarios test? The plots are being addeed in every single workflow but FastSim: data, cosmics, HI, MC, Run1, Run2, Run3, Phase2

* Have you checked in your tests if the output makes sense beyond a successful runTheMatrix -l ?

* I see that plots are added not only to the Tracking folder but in many other places like HLT, EGM, Muon, and even EXO, and in many cases empty, instead the Tracking folder has stats.

* In particular plots dubbed _DCASi__inner are always empty for every workflow and every folder, while DistanceOfClosestApproachAlongZ* in the same folder are totally filled with plenty of stats, is this expected?
  Thanks

@mtosi

This was referenced Apr 24, 2020
@arossi83
Copy link
Contributor

Hi @mtosi, are the plots on OfflinePV not sufficient to monitor such quantities? https://tinyurl.com/y7f66a4d
Here the code where those plots are filled: https://github.com/cms-sw/cmssw/blob/master/DQMOffline/RecoB/plugins/PrimaryVertexMonitor.cc

@silviodonato
Copy link
Contributor

Kind reminder @mtosi

@silviodonato
Copy link
Contributor

Just a reminder that 11_1_X will be closed to new features in one week.

@silviodonato
Copy link
Contributor

Please let me know as soon as you want to open back this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants