-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New developments using multiple data catalogs provided in site-local-config.xml #28911
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28911/13702
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28911/13704
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
Please update the title of this to PR to something more readable. |
fc63269
to
7c8ab86
Compare
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28911/13783
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28911/13784
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+1
|
+1 |
+1 |
+1 |
Do you have any comments @rekovic ? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This request proposes code changes to use multiple data catalogs listed in site-local-config.xml. Previously, the site-local-config.xml contains two data catalogs, primary and fallback ones. These are parsed and used by CMSSW using dedicated methods and functions.
The idea is to add a pfns_ variable to FileCatalogItem class (FWCore/Catalog/interface/InputFileCatalog.h ), to store all the physical file names. Each of them corresponds to a data catalog. The collection of data catalogs is returned by SiteLocalConfigService. The FileCatalogItems for all input files (each item corresponds to an input file) are store in InputFileCatalog, which is the interface to access input file catalog.
When an input file is read or opened by a source (PoolSource for example), a loop over its names formed from available catalogs is used until the file can be opened successfully by a valid catalog. Otherwise, exception is thrown. This mechanism replaces the use of primary and fallback catalogs in the past. Examples can be found in "initTheFile" (https://github.com/nhduongvn/cmssw/blob/dev-dataCatalog-1-forPR/IOPool/Input/src/RootInputFileSequence.cc)