Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New developments using multiple data catalogs provided in site-local-config.xml #28911

Merged
merged 19 commits into from
May 14, 2020

Conversation

nhduongvn
Copy link
Contributor

@nhduongvn nhduongvn commented Feb 10, 2020

PR description:

This request proposes code changes to use multiple data catalogs listed in site-local-config.xml. Previously, the site-local-config.xml contains two data catalogs, primary and fallback ones. These are parsed and used by CMSSW using dedicated methods and functions.

The idea is to add a pfns_ variable to FileCatalogItem class (FWCore/Catalog/interface/InputFileCatalog.h ), to store all the physical file names. Each of them corresponds to a data catalog. The collection of data catalogs is returned by SiteLocalConfigService. The FileCatalogItems for all input files (each item corresponds to an input file) are store in InputFileCatalog, which is the interface to access input file catalog.

When an input file is read or opened by a source (PoolSource for example), a loop over its names formed from available catalogs is used until the file can be opened successfully by a valid catalog. Otherwise, exception is thrown. This mechanism replaces the use of primary and fallback catalogs in the past. Examples can be found in "initTheFile" (https://github.com/nhduongvn/cmssw/blob/dev-dataCatalog-1-forPR/IOPool/Input/src/RootInputFileSequence.cc)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28911/13702

  • This PR adds an extra 76KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28911/13704

  • This PR adds an extra 80KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@silviodonato
Copy link
Contributor

Please update the title of this to PR to something more readable.
Please rebase this PR starting from a recent release (eg. CMSSW_11_1_X_2020-02-11-1100) or at least CMSSW_11_1_0_pre2.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@nhduongvn nhduongvn changed the title Dev data catalog 1 for pr New developments using multiple data catalogs provided in site-local-config.xml Feb 13, 2020
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28911/13783

  • This PR adds an extra 84KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28911/13784

  • This PR adds an extra 84KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@slava77
Copy link
Contributor

slava77 commented May 6, 2020

@agrohsje
Copy link

agrohsje commented May 8, 2020

+1

@mommsen
Copy link
Contributor

mommsen commented May 8, 2020

+1

@pohsun
Copy link

pohsun commented May 11, 2020

+1

@silviodonato
Copy link
Contributor

Do you have any comments @rekovic ?

@rekovic
Copy link
Contributor

rekovic commented May 13, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.