-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getProducerParameterSet #29148
getProducerParameterSet #29148
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29148/14080
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29148/14081
|
A new Pull Request was created by @tschuh for master. It involves the following packages: FWCore/Framework @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@tschuh , please update the title of this PR |
@tschuh Could you please explain the motivation for the new overload? |
I have no idea how to get the Provenance of an ESProducer. But I was able to figure out process name and the module label. |
If you get the data from the EventSetup, you can ask the ESHandle for the |
I struggle to get the ESProducer. If I do what I naively expect I have to do like: |
To get an ESProduct from the EventSetup an ESProducer is needed (+ESSource for the record) in the configuration. From your message I interpret that your job does not have one. Are you then trying to access the ParameterSet of a job that produced the input of your job? |
I am working with RelVal samples. They contain TTStubs using a TTStubAlgorithm during production. Unfortunately I need something from the TTStubAlgorithm which has not been stored in the TTStubs. Therefore I am reconstructing the TTStubAlgorithm and I want to ensure that it uses the same configuration as the TTStubAlgorithm during production. Since the configuration has been stored in the samples I am extracting that from there. |
Could you just include the configuration of the same ESProducer in your job than what was run in the RelVal? The provenance system is not intended to propagate configuration values from an earlier job to a later job, but to have the ability to (mostly visually) inspect how a given event has been processed. (of course it can be abused to propagate values, but then you are on your own). Said that, the inability to propagate configuration fragments is a weakness in our configuration system. |
Well, I could load the default release configurations. However, people are playing with this bend window configuration and tracker geometries for example. I can never be sure that for a given relval sample the default config has been used (by purpose or by mistake). |
So RelVals are being produced with customize functions (or customize commands) altering these parameters? |
@tschuh do you still need this PR? |
Ah sorry, got distracted. I use the code from this PR in PR #29151 which seems half approved. So it would be nice, else wise I will likely define the function somewhere else. This seems the correct place for me but I don't mind where it goes. |
As I mentioned in #29151 (comment), we do not really like this use of |
-1 |
Alright, no worries and many thanks for the help so far. |
PR description:
second getProducerParameterSet function to get ParameterSet of module without Provenance.
PR validation:
only build of FWCore/Framework without git cms-checkdeps -a -A