New EDProducer emulating the Stub processing of the Phase 2 Outer Tracker DTC board #29151

tschuh · 2020-03-09T10:44:57Z

PR description:

New EDProducer emulating the Stub processing of the Phase 2 Outer Tracker DTC boards and it's Product. The Pruduct has been added to the EventContent and the Producer to the StandardSequence as other Track Trigger modules which are already present.

PR validation:

build of DataFormats/L1TrackTrigger and L1Trigger/L1TTrackerDTC only
run of L1Trigger/L1TTrackerDTC/test/test_cfg.py

Notes:

I did not template the DTCProducer, it can handle only
TTStub<edm::Ref<edm::DetSetVector, Phase2TrackerDigi>>.
I don't understand why TTStub and TTCluster are templated in first place.

cmsbuild · 2020-03-09T10:45:28Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-03-09T10:49:55Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29151/14086

This PR adds an extra 72KB to repository
Found files with invalid states:
- nbproject/project.xml:
  - Added: 9e841ff
  - Deleted: 9d26595
- nbproject/configurations.xml:
  - Added: 9e841ff
  - Deleted: 9d26595
- nbproject/private/cpp_standard_headers_indexer.cpp:
  - Added: 9e841ff
  - Deleted: 9d26595
- nbproject/private/private.xml:
  - Added: 9e841ff
  - Deleted: 9d26595
- nbproject/private/c_standard_headers_indexer.c:
  - Added: 9e841ff
  - Deleted: 9d26595
- nbproject/private/launcher.properties:
  - Added: 9e841ff
  - Deleted: 9d26595
- nbproject/private/configurations.xml:
  - Added: 9e841ff
  - Deleted: 9d26595
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/EventContent/python/EventContent_cff.py modified in PR(s): PPS: rename directories with misleading names #29137, [HGCAL] TICL in reconstruction #29081
- File DataFormats/L1TrackTrigger/BuildFile.xml modified in PR(s): Pr 111x L1t Phase2 DataFormats step1 #29038
- File DataFormats/L1TrackTrigger/interface/TTTypes.h modified in PR(s): Update TTTrack for chi2 split #28793
- File DataFormats/L1TrackTrigger/src/classes_def.xml modified in PR(s): Pr 111x L1t Phase2 DataFormats step1 #29038, Update TTTrack for chi2 split #28793

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29151/14086/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29151/14086/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

smuzaffar · 2020-03-09T10:50:24Z

@tschuh , please update the title of this PR

smuzaffar · 2020-03-09T10:51:22Z

please cleanup the history and remove the reference to these nbproject/* files

cmsbuild · 2020-03-09T11:05:25Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-03-09T11:06:53Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-03-09T11:11:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29151/14088

This PR adds an extra 84KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/EventContent/python/EventContent_cff.py modified in PR(s): PPS: rename directories with misleading names #29137, [HGCAL] TICL in reconstruction #29081
- File DataFormats/L1TrackTrigger/BuildFile.xml modified in PR(s): Pr 111x L1t Phase2 DataFormats step1 #29038
- File DataFormats/L1TrackTrigger/interface/TTTypes.h modified in PR(s): Update TTTrack for chi2 split #28793
- File DataFormats/L1TrackTrigger/src/classes_def.xml modified in PR(s): Pr 111x L1t Phase2 DataFormats step1 #29038, Update TTTrack for chi2 split #28793

cmsbuild · 2020-03-09T11:11:38Z

A new Pull Request was created by @tschuh for master.

It involves the following packages:

Configuration/EventContent
Configuration/StandardSequences
DataFormats/L1TrackTrigger
L1Trigger/L1TTrackerDTC

The following packages do not have a category, yet:

L1Trigger/L1TTrackerDTC
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@benkrikler, @silviodonato, @kpedro88, @cmsbuild, @rekovic, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @sviret, @lecriste, @dgulhan this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

DataFormats/L1TrackTrigger/BuildFile.xml

DataFormats/L1TrackTrigger/interface/TTBV.h

DataFormats/L1TrackTrigger/interface/TTDTC.h

DataFormats/L1TrackTrigger/interface/TTTypes.h

L1Trigger/L1TTrackerDTC/README.md

L1Trigger/L1TTrackerDTC/src/Settings.cc

L1Trigger/L1TTrackerDTC/src/Stub.cc

L1Trigger/L1TTrackerDTC/test/MCsamples/1110/RelVal/DisplacedMuPt10To30/noPU.txt

kpedro88 · 2020-03-09T15:25:40Z

please test

cmsbuild · 2020-03-09T15:26:09Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5073/console Started: 2020/03/09 16:35

silviodonato · 2020-04-06T10:01:00Z

+operations

silviodonato · 2020-04-06T10:01:42Z

@rekovic @benkrikler @pohsun @tlampen @tocheng @christopheralanwest
do you have further comments?

boudoul · 2020-04-06T10:10:11Z

Hello I do not think that the title is explicit for any of us, maybe at least changing it with 'New EDProducer emulating the Stub processing of the Phase 2 Outer Tracker DTC board' would be already much more explicit

rekovic · 2020-04-09T16:06:02Z

+1

silviodonato · 2020-04-14T08:34:18Z

alca: @pohsun @tlampen @tocheng @christopheralanwest ?

tocheng · 2020-04-14T09:10:28Z

+1

cmsbuild · 2020-04-14T09:10:58Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-04-14T12:56:51Z

code-checks

cmsbuild · 2020-04-14T12:57:18Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-04-14T13:03:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29151/14674

This PR adds an extra 160KB to repository
Found files with invalid states:
- L1Trigger/L1TTrackerDTC/plugins/BuildFile.xml:
  - Added: 133b216
  - Deleted: 1414820
- L1Trigger/TrackerDTC/plugins/TrackerDTCProducer.h:
  - Added: 1414820
  - Deleted: 3fdd35a
- L1Trigger/L1TTrackerDTC/interface/TTDTCConverter.h:
  - Added: 133b216
  - Modified: 102a887
  - Deleted: 1414820
- L1Trigger/L1TTrackerDTC/src/TTDTCConverter.cc:
  - Added: 133b216
  - Modified: 102a887
  - Deleted: 1414820
- L1Trigger/L1TTrackerDTC/BuildFile.xml:
  - Added: 133b216
  - Deleted: 1414820
- L1Trigger/L1TTrackerDTC/python/Producer_Defaults_cfi.py:
  - Added: 133b216
  - Deleted: 1414820
- L1Trigger/TrackerDTC/plugins/TrackerDTCProducer.cc:
  - Added: 1414820
  - Modified: 3fdd35a, d098144, b7491bf
  - Deleted: d7a9441
- L1Trigger/L1TTrackerDTC/interface/Settings.h:
  - Added: 133b216
  - Modified: 102a887
  - Deleted: 1414820
- L1Trigger/L1TTrackerDTC/interface/DTC.h:
  - Added: 133b216
  - Modified: 102a887
  - Deleted: 1414820
- L1Trigger/L1TTrackerDTC/python/Producer_cff.py:
  - Added: 133b216
  - Deleted: 1414820
- L1Trigger/TrackerDTC/python/Producer_Costumize_cff.py:
  - Added: d098144
  - Deleted: d7a9441
- L1Trigger/L1TTrackerDTC/test/test_cfg.py:
  - Added: 133b216
  - Deleted: 1414820
- L1Trigger/L1TTrackerDTC/python/Format_TMTT_cfi.py:
  - Added: 133b216
  - Deleted: 1414820
- L1Trigger/L1TTrackerDTC/plugins/L1TTrackerDTCProducer.h:
  - Added: 133b216
  - Modified: 102a887
  - Deleted: 1414820
- L1Trigger/L1TTrackerDTC/src/Stub.cc:
  - Added: 133b216
  - Modified: 102a887
  - Deleted: 1414820
- L1Trigger/L1TTrackerDTC/src/Settings.cc:
  - Added: 133b216
  - Modified: 102a887
  - Deleted: 1414820
- L1Trigger/L1TTrackerDTC/src/DTC.cc:
  - Added: 133b216
  - Modified: 102a887
  - Deleted: 1414820
- L1Trigger/L1TTrackerDTC/interface/Stub.h:
  - Added: 133b216
  - Modified: 102a887
  - Deleted: 1414820
- L1Trigger/L1TTrackerDTC/interface/Module.h:
  - Added: 133b216
  - Modified: 102a887
  - Deleted: 1414820
- L1Trigger/L1TTrackerDTC/src/Module.cc:
  - Added: 133b216
  - Modified: 102a887
  - Deleted: 1414820
- L1Trigger/L1TTrackerDTC/plugins/L1TTrackerDTCProducer.cc:
  - Added: 133b216
  - Modified: 102a887
  - Deleted: 1414820
- L1Trigger/L1TTrackerDTC/python/Format_Hybrid_cfi.py:
  - Added: 133b216
  - Deleted: 1414820
- L1Trigger/TrackerDTC/src/TTDTCConverter.cc:
  - Added: 1414820
  - Modified: 3fdd35a
  - Deleted: d098144

silviodonato · 2020-04-14T13:19:55Z

+1

silviodonato · 2020-04-15T06:59:19Z

A unit test is failing in the last IB and likely the reason is related to this PR.
Could you please have a look at #29474?

cmsbuild added this to the CMSSW_11_1_X milestone Mar 9, 2020

cmsbuild added code-checks-pending comparison-pending l1-pending new-package-pending operations-pending orp-pending pending-signatures tests-pending upgrade-pending labels Mar 9, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 9, 2020

tschuh changed the title B L1TTrackerDTC Mar 9, 2020

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 9, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 9, 2020

tschuh mentioned this pull request Mar 9, 2020

L1TTrackerDTC cms-sw/cms-bot#1273

Merged

kpedro88 reviewed Mar 9, 2020

View reviewed changes

cmsbuild removed the tests-pending label Mar 9, 2020

cmsbuild added operations-approved and removed operations-pending labels Apr 6, 2020

tschuh changed the title ~~L1TTrackerDTC~~ New EDProducer emulating the Stub processing of the Phase 2 Outer Tracker DTC board Apr 6, 2020

tschuh mentioned this pull request Apr 7, 2020

getProducerParameterSet #29148

Closed

cmsbuild added l1-approved and removed l1-pending labels Apr 9, 2020

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Apr 14, 2020

cmsbuild added code-checks-pending and removed code-checks-approved labels Apr 14, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 14, 2020

cmsbuild added orp-approved and removed orp-pending labels Apr 14, 2020

cmsbuild merged commit 2ee9004 into cms-sw:master Apr 14, 2020

silviodonato mentioned this pull request Apr 15, 2020

SLHCUpgradeSimulations/Geometry unit test failure #29474

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New EDProducer emulating the Stub processing of the Phase 2 Outer Tracker DTC board #29151

New EDProducer emulating the Stub processing of the Phase 2 Outer Tracker DTC board #29151

tschuh commented Mar 9, 2020

cmsbuild commented Mar 9, 2020

cmsbuild commented Mar 9, 2020

smuzaffar commented Mar 9, 2020

smuzaffar commented Mar 9, 2020

cmsbuild commented Mar 9, 2020

cmsbuild commented Mar 9, 2020

cmsbuild commented Mar 9, 2020

cmsbuild commented Mar 9, 2020

kpedro88 commented Mar 9, 2020

cmsbuild commented Mar 9, 2020 •

edited

Loading

silviodonato commented Apr 6, 2020

silviodonato commented Apr 6, 2020

boudoul commented Apr 6, 2020

rekovic commented Apr 9, 2020

silviodonato commented Apr 14, 2020

tocheng commented Apr 14, 2020

cmsbuild commented Apr 14, 2020

silviodonato commented Apr 14, 2020

cmsbuild commented Apr 14, 2020

cmsbuild commented Apr 14, 2020

silviodonato commented Apr 14, 2020

silviodonato commented Apr 15, 2020

New EDProducer emulating the Stub processing of the Phase 2 Outer Tracker DTC board #29151

New EDProducer emulating the Stub processing of the Phase 2 Outer Tracker DTC board #29151

Conversation

tschuh commented Mar 9, 2020

PR description:

PR validation:

Notes:

cmsbuild commented Mar 9, 2020

cmsbuild commented Mar 9, 2020

smuzaffar commented Mar 9, 2020

smuzaffar commented Mar 9, 2020

cmsbuild commented Mar 9, 2020

cmsbuild commented Mar 9, 2020

cmsbuild commented Mar 9, 2020

cmsbuild commented Mar 9, 2020

kpedro88 commented Mar 9, 2020

cmsbuild commented Mar 9, 2020 • edited Loading

silviodonato commented Apr 6, 2020

silviodonato commented Apr 6, 2020

boudoul commented Apr 6, 2020

rekovic commented Apr 9, 2020

silviodonato commented Apr 14, 2020

tocheng commented Apr 14, 2020

cmsbuild commented Apr 14, 2020

silviodonato commented Apr 14, 2020

cmsbuild commented Apr 14, 2020

cmsbuild commented Apr 14, 2020

silviodonato commented Apr 14, 2020

silviodonato commented Apr 15, 2020

cmsbuild commented Mar 9, 2020 •

edited

Loading