-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Geant] Updates needed for Geant 10.6 #28626
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28626/13161
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages: SimG4Core/PrintGeomInfo @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The tests are being triggered in jenkins.
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
-1 Tested at: ffec687 CMSSW: CMSSW_11_1_GEANT4_X_2019-12-12-2300 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: Entering library rule at src/SimG4CMS/PPS/plugins >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_GEANT4_X_2019-12-12-2300/src/SimG4CMS/PPS/plugins/module.cc >> Building edm plugin tmp/slc7_amd64_gcc820/src/SimG4CMS/PPS/plugins/SimG4CMSPPSPlugins/libSimG4CMSPPSPlugins.so Leaving library rule at src/SimG4CMS/PPS/plugins @@@@ Running edmWriteConfigs for SimG4CMSPPSPlugins error: edmWriteConfigs caught an exception while loading a plugin library. The executable will return success (0) so scram will continue, but no cfi files will be written. An exception of category 'PluginLibraryLoadError' occurred. Exception Message: unable to load /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_GEANT4_X_2019-12-12-2300/tmp/slc7_amd64_gcc820/src/SimG4CMS/PPS/plugins/SimG4CMSPPSPlugins/libSimG4CMSPPSPlugins.so because libCLHEP-2.4.1.2.so: cannot open shared object file: No such file or directory The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
The tests are being triggered in jenkins.
|
-1 Tested at: ffec687 CMSSW: CMSSW_11_1_GEANT4_X_2019-12-12-2300 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests RelVals AddOn
I found errors in the following unit tests: ---> test materialBudgetTrackerPlots had ERRORS
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step1_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log101.0 step1 runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log12434.0 step1 runTheMatrix-results/12434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023/step1_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023.log250202.181 step2 runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step2_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log
I found errors in the following addon tests: cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_MC.root : FAILED - time: date Mon Dec 16 23:11:26 2019-date Mon Dec 16 23:04:06 2019 s - exit: 34304 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: ffec687 CMSSW: CMSSW_11_1_X_2019-12-16-2300 I found follow errors while testing this PR Failed tests: Build ClangBuild
I found compilation error when building: >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomSummary.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintSensitive.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc >> Compiling bigobj edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintSensitive.cc /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc: In member function 'void PrintGeomInfoAction::dumpG4LVLeaf(G4LogicalVolume*, unsigned int, unsigned int, std::ostream&)': /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc:176:26: error: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'G4int' {aka 'int'} [-Werror=sign-compare] for (size_t ii = 0; ii < lv->GetNoDaughters(); ii++) { ~~~^~~~~~~~~~~~~~~~~~~~~~ /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc: In member function 'void PrintGeomInfoAction::add1touchable(G4LogicalVolume*, int&)': /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc:195:26: error: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'G4int' {aka 'int'} [-Werror=sign-compare] for (size_t ii = 0; ii < lv->GetNoDaughters(); ii++)
I found compilation error while trying to compile with clang. Command used:
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/module.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomSummary.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintSensitive.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintMaterialBudgetInfo.cc /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc:176:26: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'G4int' (aka 'int') [-Werror,-Wsign-compare] for (size_t ii = 0; ii < lv->GetNoDaughters(); ii++) { ~~ ^ ~~~~~~~~~~~~~~~~~~~~ /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc:195:26: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'G4int' (aka 'int') [-Werror,-Wsign-compare] for (size_t ii = 0; ii < lv->GetNoDaughters(); ii++) ~~ ^ ~~~~~~~~~~~~~~~~~~~~ |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
The tests are being triggered in jenkins.
|
closing it in favor of #28637 |
New Geant4 10.6 complains about ( cms-sw/cmsdist#5424 (comment) )
This PR uses the correct type
size_t
to fix this warnings