Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Geant] Updates needed for Geant 10.6 #28626

Closed
wants to merge 1 commit into from
Closed

Conversation

smuzaffar
Copy link
Contributor

New Geant4 10.6 complains about ( cms-sw/cmsdist#5424 (comment) )

error: comparison of integer expressions of different signedness: 'int' and 'size_t' {aka 'long unsigned int'} [-Werror=sign-compare]

This PR uses the correct type size_t to fix this warnings

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28626/13161

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

SimG4Core/PrintGeomInfo

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 15, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5424,cms-externals/geant4#43
Test Parameters:

@civanch
Copy link
Contributor

civanch commented Dec 15, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

-1

Tested at: ffec687

CMSSW: CMSSW_11_1_GEANT4_X_2019-12-12-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6720ce/3983/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6720ce/3983/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6720ce/3983/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

Entering library rule at src/SimG4CMS/PPS/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_GEANT4_X_2019-12-12-2300/src/SimG4CMS/PPS/plugins/module.cc 
>> Building edm plugin tmp/slc7_amd64_gcc820/src/SimG4CMS/PPS/plugins/SimG4CMSPPSPlugins/libSimG4CMSPPSPlugins.so
Leaving library rule at src/SimG4CMS/PPS/plugins
@@@@ Running edmWriteConfigs for SimG4CMSPPSPlugins
error: edmWriteConfigs caught an exception while loading a plugin library.
The executable will return success (0) so scram will continue,
but no cfi files will be written.
An exception of category 'PluginLibraryLoadError' occurred.
Exception Message:
unable to load /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_GEANT4_X_2019-12-12-2300/tmp/slc7_amd64_gcc820/src/SimG4CMS/PPS/plugins/SimG4CMSPPSPlugins/libSimG4CMSPPSPlugins.so because libCLHEP-2.4.1.2.so: cannot open shared object file: No such file or directory


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6720ce/3983/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6720ce/3983/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 16, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5424,cms-externals/geant4#43,#28629
Test Parameters:

@cmsbuild
Copy link
Contributor

-1

Tested at: ffec687

CMSSW: CMSSW_11_1_GEANT4_X_2019-12-12-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a9028/3987/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a9028/3987/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a9028/3987/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals AddOn

  • Unit Tests:

I found errors in the following unit tests:

---> test materialBudgetTrackerPlots had ERRORS
---> test testTauEmbeddingProducers had ERRORS

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
8.0 step1

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step1_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

101.0 step1
runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

12434.0 step1
runTheMatrix-results/12434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023/step1_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023.log

250202.181 step2
runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step2_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_MC.root : FAILED - time: date Mon Dec 16 23:11:26 2019-date Mon Dec 16 23:04:06 2019 s - exit: 34304
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_2018 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_2018_MC.root : FAILED - time: date Mon Dec 16 23:17:41 2019-date Mon Dec 16 23:04:08 2019 s - exit: 34304
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Mon Dec 16 23:16:42 2019-date Mon Dec 16 23:04:17 2019 s - exit: 34304
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Mon Dec 16 23:11:50 2019-date Mon Dec 16 23:04:28 2019 s - exit: 34304
cmsDriver.py TTbar_Tauola_8TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Mon Dec 16 23:11:39 2019-date Mon Dec 16 23:04:37 2019 s - exit: 34304
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018_pp_on_AA --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Mon Dec 16 23:13:41 2019-date Mon Dec 16 23:04:42 2019 s - exit: 34304
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_MC.root : FAILED - time: date Mon Dec 16 23:11:39 2019-date Mon Dec 16 23:04:43 2019 s - exit: 34304
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Mon Dec 16 23:13:51 2019-date Mon Dec 16 23:08:51 2019 s - exit: 34304

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a9028/3987/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a9028/3987/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 16, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4008/console Started: 2019/12/17 04:58

@cmsbuild
Copy link
Contributor

-1

Tested at: ffec687

CMSSW: CMSSW_11_1_X_2019-12-16-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae414a/4008/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

  • Build:

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomSummary.cc 
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintSensitive.cc 
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc 
>> Compiling bigobj edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintSensitive.cc 
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc: In member function 'void PrintGeomInfoAction::dumpG4LVLeaf(G4LogicalVolume*, unsigned int, unsigned int, std::ostream&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc:176:26: error: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'G4int' {aka 'int'} [-Werror=sign-compare]
   for (size_t ii = 0; ii < lv->GetNoDaughters(); ii++) {
                       ~~~^~~~~~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc: In member function 'void PrintGeomInfoAction::add1touchable(G4LogicalVolume*, int&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc:195:26: error: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'G4int' {aka 'int'} [-Werror=sign-compare]
   for (size_t ii = 0; ii < lv->GetNoDaughters(); ii++)

  • Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/module.cc 
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomSummary.cc 
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintSensitive.cc 
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc 
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintMaterialBudgetInfo.cc 
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc:176:26: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'G4int' (aka 'int') [-Werror,-Wsign-compare]
  for (size_t ii = 0; ii < lv->GetNoDaughters(); ii++) {
                      ~~ ^ ~~~~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2019-12-16-2300/src/SimG4Core/PrintGeomInfo/src/PrintGeomInfoAction.cc:195:26: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'G4int' (aka 'int') [-Werror,-Wsign-compare]
  for (size_t ii = 0; ii < lv->GetNoDaughters(); ii++)
                      ~~ ^ ~~~~~~~~~~~~~~~~~~~~


@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 17, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5424,cms-externals/geant4#43,#28629
Test Parameters:

@smuzaffar
Copy link
Contributor Author

closing it in favor of #28637

@smuzaffar smuzaffar closed this Dec 18, 2019
@smuzaffar smuzaffar deleted the smuzaffar-patch-2 branch December 18, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants