Fix dependency and use root tools instead of explicit lib names

[smuzaffar]

PR description:

• Added dependency on rootrgl to fix UBSAN IBs errors

ld: Fireworks/Geometry/plugins/FireworksDisplayGeomPlugin/DisplayGeom.cc.o:(.data.rel+0xdd8): undefined reference to `typeinfo for TGLSceneBase'
ld: Fireworks/Eve/plugins/FireworksEveDummyEvelyserPlugin/DummyEvelyser.cc.o:(.data.rel+0x2318): undefined reference to `typeinfo for TGLSceneBase'

• Use root tools instead of explicit library names in BuildFiles.

[cmsbuild]

The code-checks are being triggered in jenkins.

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28583/13079

• This PR adds an extra 20KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3867/console Started: 2019/12/09 10:06

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

Fireworks/Calo
Fireworks/Candidates
Fireworks/Core
Fireworks/Electrons
Fireworks/Eve
Fireworks/FWInterface
Fireworks/GenParticle
Fireworks/Geometry
Fireworks/Muons
Fireworks/ParticleFlow
Fireworks/SimData
Fireworks/Tracks
Fireworks/Vertices

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: dbbf940
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91a21e/3867/summary.html

[cmsbuild]

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

[smuzaffar]

please test

[smuzaffar]

please test with cms-sw/cmsdist#5416

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5416
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3874/console Started: 2019/12/09 12:28

[cmsbuild]

+1
Tested at: 4a6fd98
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-576f61/3874/summary.html

[cmsbuild]

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

[fabiocos]

@alja do you see any issue with this? otherwise could you please sign it?

[alja]

+1
Thank You!

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1