Skip to content

Commit

Permalink
Merge pull request #28583 from smuzaffar/ubsab-root-tools
Browse files Browse the repository at this point in the history
Fix dependency and use root tools instead of explicit lib names
  • Loading branch information
cmsbuild authored Dec 13, 2019
2 parents d239aa6 + 4a6fd98 commit e2254c4
Show file tree
Hide file tree
Showing 24 changed files with 78 additions and 81 deletions.
4 changes: 2 additions & 2 deletions Fireworks/Calo/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
<use name="boost_system"/>
<use name="rootgpad"/>
<use name="rootphysics"/>
<lib name="Eve"/>
<lib name="Geom"/>
<use name="rooteve"/>
<use name="rootgeom"/>
<export>
<lib name="1"/>
</export>
6 changes: 3 additions & 3 deletions Fireworks/Calo/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
<use name="Fireworks/Core"/>
<use name="Fireworks/Tracks"/>
<use name="rootinteractive"/>
<lib name="Eve"/>
<lib name="RGL"/>
<lib name="Geom"/>
<use name="rooteve"/>
<use name="rootrgl"/>
<use name="rootgeom"/>
<flags EDM_PLUGIN="1"/>
</library>
2 changes: 1 addition & 1 deletion Fireworks/Candidates/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<use name="boost_system"/>
<use name="Fireworks/Core"/>
<use name="Fireworks/Calo"/>
<lib name="Eve"/>
<use name="rooteve"/>
<export>
<lib name="1"/>
</export>
4 changes: 2 additions & 2 deletions Fireworks/Candidates/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<use name="DataFormats/Candidate"/>
<use name="Fireworks/Candidates"/>
<use name="Fireworks/Core"/>
<lib name="Eve"/>
<lib name="RGL"/>
<use name="rooteve"/>
<use name="rootrgl"/>
<flags EDM_PLUGIN="1"/>
</library>
23 changes: 9 additions & 14 deletions Fireworks/Core/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -26,20 +26,15 @@
<use name="rootgraphics"/>
<use name="sigcpp"/>
<use name="rootged"/>
<lib name="Thread"/>
<lib name="Eve"/>
<lib name="Geom"/>
<lib name="GeomPainter"/>
<lib name="GuiHtml"/>
<architecture name="!osx10">
<lib name="GX11"/>
</architecture>
<architecture name="osx10">
<lib name="GCocoa"/>
</architecture>
<lib name="RGL"/>
<lib name="GLEW"/>
<lib name="Gui"/>
<use name="rootthread"/>
<use name="rooteve"/>
<use name="rootgeom"/>
<use name="rootgeompainter"/>
<use name="rootguihtml"/>
<use name="rootx11"/>
<use name="rootrgl"/>
<use name="rootglew"/>
<use name="rootgui"/>
<export>
<lib name="1"/>
</export>
2 changes: 1 addition & 1 deletion Fireworks/Core/bin/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<use name="FWCore/MessageLogger"/>
<use name="Fireworks/Core"/>
<use name="rootinteractive"/>
<lib name="Eve"/>
<use name="rooteve"/>
</bin>
<bin name="cmsShowSendReport" file="cmsShowSendReport.cc">
<use name="zlib"/>
Expand Down
4 changes: 2 additions & 2 deletions Fireworks/Electrons/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<use name="DataFormats/EgammaReco"/>
<use name="Fireworks/Core"/>
<use name="rootcore"/>
<lib name="Eve"/>
<lib name="Geom"/>
<use name="rooteve"/>
<use name="rootgeom"/>
<export>
<lib name="1"/>
</export>
4 changes: 2 additions & 2 deletions Fireworks/Electrons/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<use name="Fireworks/Tracks"/>
<use name="rootinteractive"/>
<use name="rootphysics"/>
<lib name="Eve"/>
<lib name="RGL"/>
<use name="rooteve"/>
<use name="rootrgl"/>
<flags EDM_PLUGIN="1"/>
</library>
6 changes: 3 additions & 3 deletions Fireworks/Eve/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
<use name="CondFormats/RunInfo"/>
<use name="rootcore"/>
<use name="rootinteractive"/>
<lib name="Geom"/>
<lib name="Gui"/>
<lib name="Eve"/>
<use name="rootgeom"/>
<use name="rootgui"/>
<use name="rooteve"/>
<export>
<lib name="1"/>
</export>
9 changes: 5 additions & 4 deletions Fireworks/Eve/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<library file="EveServicePlugin.cc"
name="FireworksEveEveServicePlugin">
<use name="Fireworks/Eve"/>
<lib name="Eve"/>
<lib name="Geom"/>
<use name="rooteve"/>
<use name="rootgeom"/>
<flags EDM_PLUGIN="1"/>
</library>

Expand All @@ -12,7 +12,8 @@
<use name="Fireworks/Geometry"/>
<use name="Fireworks/Eve"/>
<use name="Fireworks/Tracks"/>
<lib name="Eve"/>
<lib name="Geom"/>
<use name="rooteve"/>
<use name="rootgeom"/>
<use name="rootrgl"/>
<flags EDM_PLUGIN="1"/>
</library>
10 changes: 5 additions & 5 deletions Fireworks/FWInterface/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@
<use name="Fireworks/Geometry"/>
<use name="rootcore"/>
<use name="rootinteractive"/>
<lib name="Geom"/>
<lib name="Eve"/>
<lib name="RGL"/>
<lib name="GuiHtml"/>
<lib name="GX11"/>
<use name="rootgeom"/>
<use name="rooteve"/>
<use name="rootrgl"/>
<use name="rootguihtml"/>
<use name="rootx11"/>
<use name="boost_python"/>
<use name="FWCore/PythonParameterSet"/>
<export>
Expand Down
4 changes: 2 additions & 2 deletions Fireworks/FWInterface/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<use name="SimDataFormats/TrackingAnalysis"/>
<use name="SimGeneral/TrackingAnalysis"/>
<use name="rootcore"/>
<lib name="Geom"/>
<lib name="Eve"/>
<use name="rootgeom"/>
<use name="rooteve"/>

<library name="FireworksFWInterfacePlugin" file="*.cc"/>
4 changes: 2 additions & 2 deletions Fireworks/GenParticle/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<use name="Fireworks/Candidates"/>
<use name="Fireworks/Core"/>
<use name="rootcore"/>
<lib name="EG"/>
<lib name="Eve"/>
<use name="rooteg"/>
<use name="rooteve"/>
<flags EDM_PLUGIN="1"/>
</library>
6 changes: 3 additions & 3 deletions Fireworks/Geometry/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
<use name="DataFormats/SiPixelDetId"/>
<use name="Fireworks/Core"/>
<use name="rootcore"/>
<lib name="Geom"/>
<lib name="Eve"/>
<lib name="Physics"/>
<use name="rootgeom"/>
<use name="rooteve"/>
<use name="rootphysics"/>
<export>
<lib name="1"/>
</export>
23 changes: 12 additions & 11 deletions Fireworks/Geometry/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
<use name="FWCore/Framework"/>
<use name="Fireworks/Geometry"/>
<use name="Fireworks/Eve"/>
<lib name="Eve"/>
<lib name="Geom"/>
<lib name="Physics"/>
<use name="rooteve"/>
<use name="rootgeom"/>
<use name="rootphysics"/>
<use name="rootrgl"/>
<use name="MagneticField/Engine"/>
<use name="MagneticField/Records"/>
<flags EDM_PLUGIN="1"/>
Expand All @@ -14,8 +15,8 @@
<use name="Geometry/Records"/>
<use name="Fireworks/Geometry"/>
<use name="rootgpad"/>
<lib name="Eve"/>
<lib name="Geom"/>
<use name="rooteve"/>
<use name="rootgeom"/>
<flags EDM_PLUGIN="1"/>
</library>

Expand All @@ -24,7 +25,7 @@
<use name="FWCore/Framework"/>
<use name="FWCore/PluginManager"/>
<use name="FWCore/ParameterSet"/>
<lib name="Geom"/>
<use name="rootgeom"/>
<flags EDM_PLUGIN="1"/>
</library>

Expand All @@ -41,8 +42,8 @@

<library file="DumpFWRecoGeometry.cc" name="FireworksGeometryDumpFWRecoGeometryPlugin">
<use name="Fireworks/Geometry"/>
<lib name="Eve"/>
<lib name="Geom"/>
<use name="rooteve"/>
<use name="rootgeom"/>
<use name="rootcore"/>
<use name="FWCore/Framework"/>
<use name="FWCore/PluginManager"/>
Expand All @@ -58,8 +59,8 @@

<library file="DumpFWTGeoRecoGeometry.cc" name="FireworksGeometryDumpFWTGeoRecoGeometryPlugin">
<use name="Fireworks/Geometry"/>
<lib name="Eve"/>
<lib name="Geom"/>
<use name="rooteve"/>
<use name="rootgeom"/>
<use name="rootcore"/>
<use name="FWCore/Framework"/>
<use name="FWCore/PluginManager"/>
Expand All @@ -84,7 +85,7 @@
<use name="Fireworks/Core"/>
<use name="Fireworks/Tracks"/>
<use name="rootcore"/>
<lib name="Geom"/>
<use name="rootgeom"/>
<flags EDM_PLUGIN="1"/>
</library>

Expand Down
6 changes: 3 additions & 3 deletions Fireworks/Muons/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
<use name="Fireworks/Candidates"/>
<use name="Fireworks/Core"/>
<use name="Fireworks/Tracks"/>
<lib name="Eve"/>
<lib name="Geom"/>
<lib name="GeomPainter"/>
<use name="rooteve"/>
<use name="rootgeom"/>
<use name="rootgeompainter"/>
<export>
<lib name="1"/>
</export>
6 changes: 3 additions & 3 deletions Fireworks/Muons/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
<use name="Fireworks/Muons"/>
<use name="rootinteractive"/>

<lib name="Eve"/>
<lib name="Geom"/>
<lib name="RGL"/>
<use name="rooteve"/>
<use name="rootgeom"/>
<use name="rootrgl"/>
<flags EDM_PLUGIN="1"/>
</library>
2 changes: 1 addition & 1 deletion Fireworks/ParticleFlow/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<use name="Fireworks/Candidates"/>
<use name="Fireworks/Tracks"/>
<use name="Fireworks/Calo"/>
<lib name="Eve"/>
<use name="rooteve"/>
<export>
<lib name="1"/>
</export>
4 changes: 2 additions & 2 deletions Fireworks/ParticleFlow/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<use name="DataFormats/PatCandidates"/>
<use name="DataFormats/TrackReco"/>
<use name="Fireworks/ParticleFlow"/>
<lib name="Eve"/>
<lib name="RGL"/>
<use name="rooteve"/>
<use name="rootrgl"/>
<flags EDM_PLUGIN="1"/>
</library>
6 changes: 3 additions & 3 deletions Fireworks/SimData/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
<use name="SimDataFormats/Vertex"/>
<use name="SimDataFormats/TrackingAnalysis"/>
<use name="SimDataFormats/CaloAnalysis"/>
<lib name="Eve"/>
<lib name="EG"/>
<lib name="Geom"/>
<use name="rooteve"/>
<use name="rooteg"/>
<use name="rootgeom"/>
<flags EDM_PLUGIN="1"/>
</library>
2 changes: 1 addition & 1 deletion Fireworks/Tracks/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<use name="Fireworks/Core"/>
<use name="rootmath"/>
<use name="rootphysics"/>
<lib name="Eve"/>
<use name="rooteve"/>
<export>
<lib name="1"/>
</export>
6 changes: 3 additions & 3 deletions Fireworks/Tracks/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
<use name="rootinteractive"/>
<use name="rootphysics"/>

<lib name="Eve"/>
<lib name="Geom"/>
<lib name="RGL"/>
<use name="rooteve"/>
<use name="rootgeom"/>
<use name="rootrgl"/>
<flags EDM_PLUGIN="1"/>
</library>
10 changes: 5 additions & 5 deletions Fireworks/Vertices/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
<use name="Fireworks/Core"/>
<use name="rootcore"/>
<use name="opengl"/>
<lib name="Eve"/>
<lib name="Geom"/>
<lib name="Physics"/>
<lib name="RGL"/>
<lib name="Core"/>
<use name="rooteve"/>
<use name="rootgeom"/>
<use name="rootphysics"/>
<use name="rootrgl"/>
<use name="rootcling"/>
<export>
<lib name="1"/>
</export>
6 changes: 3 additions & 3 deletions Fireworks/Vertices/plugins/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
<use name="Fireworks/Vertices"/>
<use name="Fireworks/Candidates"/>
<use name="roothistmatrix"/>
<lib name="Eve"/>
<lib name="Geom"/>
<lib name="Core"/>
<use name="rooteve"/>
<use name="rootgeom"/>
<use name="rootcling"/>
<flags EDM_PLUGIN="1"/>
</library>

0 comments on commit e2254c4

Please sign in to comment.