-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DQM] Bin by bin normalization off by default #28616
[DQM] Bin by bin normalization off by default #28616
Conversation
please test |
The code-checks are being triggered in jenkins. |
This PR is fixing this issue: #28442 (comment) |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28616/13140
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @andrius-k (Andrius) for master. It involves the following packages: DQMServices/FileIO @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@andrius-k , I am testing cms-sw/cmsdist#5537 and noticed that this test does not run under python3 (CMSSW_11_1_PY3_X IBs). Please see the errors here Can you please provide a fix for python3? |
@smuzaffar Thanks for spotting this. visDQMUpload is not compatible with python3 - I will fix this. |
Hi @smuzaffar, |
PR description:
Normalization is now off by default in the DQM GUI when exploring bin by bin tool results in an overlay view.
PR validation:
PR was validated locally.