Add enforceGUIDInFileName option to PoolSource and EmbeddedRootSource

[makortel]

PR description:

This PR adds an option to PoolSource and EmbeddedRootSource to enforce that the file name (without extension) corresponds the GUID of the file. The added configuration parameter is enforceGUIDInFileName = cms.untracked.bool, and is set to false by default to preserve the current behavior. In case of a mismatch a new error code 8034 (FileNameInconsistentWithGUID) is returned.

The motivation for such an option comes from dmwm/WMCore#9432.

PR validation:

Unit tests run, matrix workflow 250202.181 runs (exercises the RootEmbeddedFileSequence).

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28561/13048

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File IOPool/Input/src/RootFile.cc modified in PR(s): Faster setup of EventPrincipal #28505

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/Framework
FWCore/Utilities
IOPool/Input

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@felicepantaleo, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3830/console Started: 2019/12/05 18:26

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28561/13053

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File IOPool/Input/src/RootFile.cc modified in PR(s): Faster setup of EventPrincipal #28505

[cmsbuild]

Pull request #28561 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again.

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

-1

Tested at: d7ff852

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3f311/3858/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3f311/3858/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2800084
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2799742
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[fabiocos]

+1

the failre is independent on this PR

[fabiocos]

merge

[makortel]

I've updated the twiki documentation by

• adding the new parameter to https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideEDMParametersForModules#PoolSource
• adding the new exit code to https://twiki.cern.ch/twiki/bin/view/CMSPublic/JobExitCodes