Add enforceGUIDInFileName option to PoolSource and EmbeddedRootSource (11_0_X)

[makortel]

PR description:

Quoting original PR

This PR adds an option to PoolSource and EmbeddedRootSource to enforce that the file name (without extension) corresponds the GUID of the file. The added configuration parameter is enforceGUIDInFileName = cms.untracked.bool, and is set to false by default to preserve the current behavior. In case of a mismatch a new error code 8034 (FileNameInconsistentWithGUID) is returned.

The motivation for such an option comes from dmwm/WMCore#9432.

PR validation:

(Relevant) tests in #28561 worked, no problems in IBs.

if this PR is a backport please specify the original PR:

Backport of #28561 (using exactly the same branch otherwise exactly the same branch but adding a commit cleaning up FWCore/Utilities/test/BuildFile.xml).

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_11_0_X.

It involves the following packages:

FWCore/Framework
FWCore/MessageLogger
FWCore/Utilities
IOPool/Input

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@felicepantaleo, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Add enforceGUIDInFileName option to PoolSource and EmbeddedRootSource #28561

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3879/console Started: 2019/12/09 16:03

[makortel]

@cmsbuild, please abort

[cmsbuild]

Jenkins tests are aborted.

[cmsbuild]

Pull request #28586 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again.

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3880/console Started: 2019/12/09 16:29
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3890/console Started: 2019/12/09 23:04

[cmsbuild]

+1
Tested at: 5d93099
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c570a3/3890/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c570a3/3890/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2793840
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2793497
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[cmsbuild]

@makortel, CMSSW_11_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[smuzaffar]

please ignore the last comment by bot

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[Dr15Jones]

backport #28561

[fabiocos]

+1