Add enforceGUIDInFileName option to PoolSource and EmbeddedRootSource (8_0_X)

[makortel]

PR description:

Quoting original PR

This PR adds an option to PoolSource and EmbeddedRootSource to enforce that the file name (without extension) corresponds the GUID of the file. The added configuration parameter is enforceGUIDInFileName = cms.untracked.bool, and is set to false by default to preserve the current behavior. In case of a mismatch a new error code 8034 (FileNameInconsistentWithGUID) is returned.

The motivation for such an option comes from dmwm/WMCore#9432.

PR validation:

Unit tests run.

if this PR is a backport please specify the original PR:

Backport of #28561. There are two small differences wrt. original PR: stemFromPath() operates on std::string instead of std::string_view, and its unit test does not use catch2.

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X.

It involves the following packages:

FWCore/Framework
FWCore/MessageLogger
FWCore/Utilities
IOPool/Input

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@felicepantaleo, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Add enforceGUIDInFileName option to PoolSource and EmbeddedRootSource #28561

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3926/console Started: 2019/12/11 15:42

[cmsbuild]

-1

Tested at: 0d377d7

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35e9f0/3926/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test testORA_9 had ERRORS
---> test testORA_0 had ERRORS
---> test testNestedArrays had ERRORS
---> test testNamedReference had ERRORS
---> test testContainerLock had ERRORS
---> test testNameService had ERRORS
---> test testORA_5 had ERRORS
---> test testORABasicException had ERRORS
---> test testORA_7 had ERRORS
---> test testORA_4 had ERRORS
---> test testORA_6 had ERRORS
---> test testORA_1 had ERRORS
---> test testORAInit had ERRORS
---> test testORA_11 had ERRORS
---> test testORA_10 had ERRORS
---> test testORAUtility had ERRORS
---> test testORAIO had ERRORS
---> test testORA_3 had ERRORS
---> test testORA_12 had ERRORS
---> test testORA_2 had ERRORS
---> test testORA_8 had ERRORS
---> test DetectorDescriptionRegressionTestDOMCount had ERRORS
---> test runtestSimCalorimetryHGCalSimProducers had ERRORS
---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS
---> test TestPoolInput had ERRORS

[cmsbuild]

Comparison job queued.

[makortel]

Other tests than TestPoolInput look like they could be failing in the IB as well (I didn't check in detail as that seems to be rather laborious task).

The TestPoolInput fails with

%MSG-s ForkingEventSetupPreFetching:  AfterModBeginStream  11-Dec-2019 17:40:35 CET BeforeEvents
 prefetching for run 100
%MSG
%MSG-s ForkingEventSetupPreFetching:  AfterModBeginStream  11-Dec-2019 17:40:35 CET BeforeEvents
  done prefetching
%MSG
11-Dec-2019 17:40:35 CET  Closed file file:multiprocess_oneRun_test.root


A fatal system signal has occurred: external termination request
The following is the call stack containing the origin of the signal.


---> test TestPoolInput had ERRORS

The test worked fine for me locally (but I did not build the universe, maybe I'll try that next).

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35e9f0/3926/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 1044635
• DQMHistoTests: Total failures: 855
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1043672
• DQMHistoTests: Total skipped: 108
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -14 KiB( 14 files compared)
• Checked 62 log files, 7 edm output root files, 15 DQM output files

[makortel]

The test worked fine for me locally (but I did not build the universe, maybe I'll try that next).

Even after building the universe, the unit test works for me locally.

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3949/console Started: 2019/12/12 16:10

[cmsbuild]

-1

Tested at: 0d377d7

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35e9f0/3949/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals

• Unit Tests:

I found errors in the following unit tests:

---> test testNamedReference had ERRORS
---> test testContainerLock had ERRORS
---> test testNestedArrays had ERRORS
---> test testORA_0 had ERRORS
---> test testORA_9 had ERRORS
---> test testNameService had ERRORS
---> test testORA_4 had ERRORS
---> test testORA_6 had ERRORS
---> test testORA_1 had ERRORS
---> test testORABasicException had ERRORS
---> test testORA_5 had ERRORS
---> test testORA_7 had ERRORS
---> test testORA_11 had ERRORS
---> test testORA_10 had ERRORS
---> test testORAIO had ERRORS
---> test testORA_12 had ERRORS
---> test testORA_3 had ERRORS
---> test testORAInit had ERRORS
---> test testORA_2 had ERRORS
---> test testORAUtility had ERRORS
---> test testORA_8 had ERRORS
---> test DetectorDescriptionRegressionTestDOMCount had ERRORS
---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS
---> test runtestSimCalorimetryHGCalSimProducers had ERRORS

• RelVals:

When I ran the RelVals I found an error in the following workflows:
10224.0 step2

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[makortel]

The TestPoolInput test worked this time.

The failure in 10224.0 step2 is an I/O error from MixingModule for the MinBias files (Server responded with an error: [3011] No servers are available to read the file.).

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[Dr15Jones]

backport #28561

[fabiocos]

+1

[fabiocos]

merge