Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JME bugfixes port of #23499 #23557

Closed
wants to merge 1 commit into from

Conversation

rappoccio
Copy link
Contributor

Several JME bugs fixed here:

  • AK8 jets needed rawFactor to reapply jet corrections
  • AK4 jets needed muon fraction, addressing this issue
  • Trigger objects needed AK8 jets, addressing this issue

9.4.x version is #23499
10.1.x version is #23501

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rappoccio for master.

It involves the following packages:

PhysicsTools/NanoAOD

@gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28623/console Started: 2018/06/11 16:43

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23557/28623/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 114 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2901844
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901646
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1.64 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 4.53,... ): -0.328 KiB AlCaReco/SiStripCalMinBias
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

@arizzi @gpetruc this is affecting NanoAOD, please have a look

@fabiocos
Copy link
Contributor

@arizzi @gpetruc ping

@fabiocos
Copy link
Contributor

fabiocos commented Jul 6, 2018

@arizzi @gpetruc could you please check also this proposed update and sign it or comment?

@gpetruc
Copy link
Contributor

gpetruc commented Jul 6, 2018

will check now, but it would have been much easier if the PR had been done the proper way, i.e. first to cms-nanoAOD starting from the cms-nanoAOD master branch so that we can run the integration check

@gpetruc
Copy link
Contributor

gpetruc commented Jul 6, 2018

hold
#23446 should go in first

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2018

Pull request has been put on hold by @gpetruc
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Jul 6, 2018
@davidlange6
Copy link
Contributor

Your PR is unmergeable. Please have a look and possibly rebase it.

@smuzaffar smuzaffar modified the milestones: CMSSW_10_2_X, CMSSW_10_3_X Jul 17, 2018
@rappoccio rappoccio closed this Jul 24, 2018
@rappoccio rappoccio deleted the jme_bugfixes_10_2_x branch December 5, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants