Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JME bugfixes #23499

Closed
wants to merge 1 commit into from
Closed

JME bugfixes #23499

wants to merge 1 commit into from

Conversation

rappoccio
Copy link
Contributor

Several JME bugs fixed here:

  • AK8 jets needed rawFactor to reapply jet corrections
  • AK4 jets needed muon fraction, addressing this issue
  • Trigger objects needed AK8 jets, addressing this issue

10.1.x version will be forthcoming next.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2018

A new Pull Request was created by @rappoccio for CMSSW_9_4_X.

It involves the following packages:

PhysicsTools/NanoAOD

@gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28615/console Started: 2018/06/11 15:03

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23499/28615/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 107
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721224
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@gpetruc
Copy link
Contributor

gpetruc commented Jul 6, 2018

hold
#23445 first

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2018

Pull request has been put on hold by @gpetruc
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Jul 6, 2018
@davidlange6
Copy link
Contributor

Your PR is unmergeable. Please have a look and possibly rebase it.

@gpetruc
Copy link
Contributor

gpetruc commented Jul 17, 2018 via email

gpetruc added a commit to cms-nanoAOD/cmssw that referenced this pull request Jul 17, 2018
…ortests

JME bugfixes (CMSSW cms-sw#23499) rebased here for tests
@rappoccio
Copy link
Contributor Author

Thanks Giovanni, sorry, I'm at boost this week and the wifi is awful.

@rappoccio rappoccio closed this Jul 24, 2018
@rappoccio rappoccio deleted the jme_bugfixes branch December 5, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants