-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JME bugfixes port of #23499 #23501
JME bugfixes port of #23499 #23501
Conversation
A new Pull Request was created by @rappoccio for CMSSW_10_1_X. It involves the following packages: PhysicsTools/NanoAOD @gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@rappoccio do you remind me which is the master version of this PR? |
@fabiocos it's just one commit, so I cherry-picked it for both master and 94x branches. I can do the same to any others that are necessary. I did the 94x one first. |
@rappoccio sorry, 10_1_X is not the master branch, could you please have a master version as well? |
Whoops, sorry! Done in #23557. |
10_1_1 doesn't have a physics-quality nanoAOD anyway since most of what went to 9_4_X was forward-ported only to 10_2_X (IIRC that was requested), so it's not obvious to me whether there's a usecase for the 10_1_X backport of this. |
@rappoccio @gpetruc I think we can safely close this PR, please comment if you disagree |
Yes, I think this is not needed. |
Several JME bugs fixed here:
9.4.x version is #23499