Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JME bugfixes port of #23499 #23501

Closed
wants to merge 1 commit into from

Conversation

rappoccio
Copy link
Contributor

Several JME bugs fixed here:

  • AK8 jets needed rawFactor to reapply jet corrections
  • AK4 jets needed muon fraction, addressing this issue
  • Trigger objects needed AK8 jets, addressing this issue

9.4.x version is #23499

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2018

A new Pull Request was created by @rappoccio for CMSSW_10_1_X.

It involves the following packages:

PhysicsTools/NanoAOD

@gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@rappoccio rappoccio changed the title Adding some missing info for jets JME bugfixes port of #23499 Jun 6, 2018
@fabiocos
Copy link
Contributor

fabiocos commented Jun 7, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28529/console Started: 2018/06/07 10:06

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23501/28529/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2520630
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2520447
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Jun 7, 2018

@rappoccio do you remind me which is the master version of this PR?

@rappoccio
Copy link
Contributor Author

rappoccio commented Jun 7, 2018

@fabiocos it's just one commit, so I cherry-picked it for both master and 94x branches. I can do the same to any others that are necessary. I did the 94x one first.

@fabiocos
Copy link
Contributor

@rappoccio sorry, 10_1_X is not the master branch, could you please have a master version as well?

@rappoccio
Copy link
Contributor Author

Whoops, sorry! Done in #23557.

@fabiocos
Copy link
Contributor

fabiocos commented Jul 3, 2018

@arizzi @gpetruc is this PR ok for you?

@gpetruc
Copy link
Contributor

gpetruc commented Jul 6, 2018

10_1_1 doesn't have a physics-quality nanoAOD anyway since most of what went to 9_4_X was forward-ported only to 10_2_X (IIRC that was requested), so it's not obvious to me whether there's a usecase for the 10_1_X backport of this.

@fabiocos
Copy link
Contributor

@rappoccio @gpetruc I think we can safely close this PR, please comment if you disagree

@rappoccio
Copy link
Contributor Author

Yes, I think this is not needed.

@rappoccio rappoccio closed this Sep 10, 2018
@rappoccio rappoccio deleted the jme_bugfixes_10_1_x branch December 5, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants