Allow a boost on particles in MCParticlePairFilter #16425
Conversation
|
A new Pull Request was created by @echapon (Emilien Chapon) for CMSSW_8_1_X. It involves the following packages: GeneratorInterface/GenFilters @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
| @@ -38,6 +38,9 @@ | |||
| namespace edm { | |||
| class HepMCProduct; | |||
| } | |||
| namespace HepMC { | |||
There was a problem hiding this comment.
this is not needed given the way that FourVector is used below - you must have included the class definition somewhere else
There was a problem hiding this comment.
Sorry about the late reply. Would it be OK if instead of this declaration I moved the included header https://github.com/echapon/cmssw/blob/bf9d278f552c725aa16496ed0a02029303bc8b4e/GeneratorInterface/GenFilters/src/MCParticlePairFilter.cc#L6 from the .cc to the .h?
There was a problem hiding this comment.
Hi-
class FourVector;
lets you reference pointers to your class. To return a full FourVector you need an include "FourVector.h" (or where-ever the class is defined). So, this header file should work the same without the class FourVector portion.
There was a problem hiding this comment.
I've just tried to remove this part, but then it does not compile... I could also explicitly include the header where this class is define: HepMC/SimpleVector.h
There was a problem hiding this comment.
@davidlange6 sorry for the frequent pings... Could you tell me explicitly how I should change the code?
- removing the "class FourVector;" line is not an option, because it does no longer compile.
- I could instead include "SimDataFormats/GeneratorProducts/interface/HepMCProduct.h" (it is currently in the .cc)
- I could instead include "HepMC/SimpleVector.h"
There was a problem hiding this comment.
Hi @echapon - i will try to look tomorrow, something is not right in what you see.
There was a problem hiding this comment.
Hi @davidlange6 did you have a chance to have a look?
There was a problem hiding this comment.
i just did. don't really understand it. will merge and we see in the future how things progress as compilers change
|
+1 |
This change is needed to be able to apply generator-level cuts on momenta in the laboratory frame, instead of the centre of mass frame, in the case of boosted MC production (for proton-lead). Note that this is a different strategy than what was used for 5TeV pPb production (for Run1, in 53X), when a customisation swapping the boost and the filter was used instead (https://github.com/cms-sw/cmssw/blob/CMSSW_5_3_X/GeneratorInterface/HiGenCommon/python/customiseSwapVtxSmearAndProdFilter_cfi.py).
@kurtejung and @mandrenguyen are aware of this pull request.
Let me know if you have any comment on the implementation.