-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow a boost on particles in MCParticlePairFilter #16621
Conversation
A new Pull Request was created by @cmsbuild for CMSSW_9_0_X. It involves the following packages: GeneratorInterface/GenFilters @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
please test |
1 similar comment
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
This change is needed to be able to apply generator-level cuts on momenta in the laboratory frame, instead of the centre of mass frame, in the case of boosted MC production (for proton-lead). Note that this is a different strategy than what was used for 5TeV pPb production (for Run1, in 53X), when a customisation swapping the boost and the filter was used instead (https://github.com/cms-sw/cmssw/blob/CMSSW_5_3_X/GeneratorInterface/HiGenCommon/python/customiseSwapVtxSmearAndProdFilter_cfi.py).
@kurtejung and @mandrenguyen are aware of this pull request.
Let me know if you have any comment on the implementation.
Automatically ported from CMSSW_8_1_X #16425 (original by @echapon).