-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow a boost on particles in MCSingleParticle Filters #18532
Allow a boost on particles in MCSingleParticle Filters #18532
Conversation
A new Pull Request was created by @stahlleiton (Andre Stahl) for master. It involves the following packages: GeneratorInterface/GenFilters @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Hi @stahlleiton - I think this PR should be for 80X and not for 91X, correct? Maybe both if you want to have it for the next asymmetric collision run (2019-2020?) |
Hi @kurtejung . This PR is mainly intended for 80X, so I will make a backport of it as soon as possible, but I thought it was better to submit it first to the master branch. |
I have a curiosity: do you check anywhere that beta is < 1? |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Hi @govoni , I didn't include a check if beta is < 1. |
Is it fine like that, or could it create any inconsistencies in the future, in case of a mistake in the input parameters? |
Ok. I will add an if condition that returns an error message if beta is larger or equal 1. |
@davidlange6 : Thanks for your review. I included the suggested changes. If you consider them fine, I will then proceed to propagate them to the other backport PRs. |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This PR includes the option to perform a boost in the MCSingleParticleFilters in order to apply a generator-level cut on the momenta of single particles in the laboratory frame, instead of the center of mass frame, in the case of boosted MC production (for proton-lead). This PR follows the same strategy as #16425
@kurtejung , @mandrenguyen