Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Bump cepgen to 1.2.1patch1 #9041

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

forthommel
Copy link
Contributor

@forthommel forthommel commented Feb 29, 2024

Bump of CepGen to version 1.2.1patch1 (to be in sync with #9042 and #9040)

  • additionally requires bzlib2
  • collateral damage: CMake bumped to version 3.25.2

Backport of #8329, #9030, #9033
FYI: @bbilin

- additionally requires bzlib2
- collateral damage: CMake bumped to version 3.25.2
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @forthommel for branch IB/CMSSW_13_0_X/master.

@smuzaffar, @cmsbuild, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 29, 2024

cms-bot internal usage

@aandvalenzuela
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b1888/37816/summary.html
COMMIT: 866e2d4
CMSSW: CMSSW_13_0_X_2024-02-25-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9041/37816/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testDataFormatsScoutingRun3 had ERRORS

Comparison Summary

Summary:

@forthommel
Copy link
Contributor Author

This looks like an input file access error, not really related to this PR?

@aandvalenzuela
Copy link
Contributor

Yes @forthommel, looks like a glitch on the xrootd side :)
Let's get it in!

@forthommel forthommel changed the title [13_0_X] cepgen 1.2.1 [13_0_X] cepgen 1.2.1patch1 Mar 1, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2024

Pull request #9041 was updated.

@forthommel forthommel changed the title [13_0_X] cepgen 1.2.1patch1 [13_0_X] Bump cepgen to 1.2.1patch1 Mar 1, 2024
@iarspider
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2024

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b1888/37849/summary.html
COMMIT: bd7dbdd
CMSSW: CMSSW_13_0_X_2024-02-25-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9041/37849/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testDataFormatsScoutingRun3 had ERRORS

Comparison Summary

Summary:

@forthommel
Copy link
Contributor Author

I believe this PR did not remove any GluGlutoHHto2B2Tau_kl*.root file triggering this unit test failure :-)

@iarspider
Copy link
Contributor

please test

failure looks like XRootD glitch

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b1888/37879/summary.html
COMMIT: bd7dbdd
CMSSW: CMSSW_13_0_X_2024-03-03-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9041/37879/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test PhysicsToolsNanoAODToolsTestDriver had ERRORS

Comparison Summary

Summary:

  • You potentially added 229 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283620
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3283598
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@iarspider
Copy link
Contributor

+externals
the unit test is failing in IBs as well

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_0_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@forthommel
Copy link
Contributor Author

As @iarspider reported, there is a known issue for this failing PhysicsToolsNanoAODToolsTestDriver unit test: cms-sw/cmssw#44293.

@iarspider
Copy link
Contributor

@forthommel should this PR go in at the same time as CMSSW one?

@forthommel
Copy link
Contributor Author

Hi @iarspider,
It is indeed 100% linked, and the cmssw one cannot build without it.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

REMINDER @antoniovilela, @rappoccio, @sextonkennedy: This PR was tested with cms-sw/cmssw#44270, please check if they should be merged together

@forthommel
Copy link
Contributor Author

Reminder: @antoniovilela, @rappoccio, @sextonkennedy. The 13_0_X branch from cms-sw/cmssw will not build without this IB change.

@smuzaffar
Copy link
Contributor

as cms-sw/cmssw#44270 was merged with this cmsdist change, so it broke the 13.0.X Ibs (https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc11/CMSSW_13_0_X_2024-03-10-2300/GeneratorInterface/CepGenInterface )

I am merging it now

@smuzaffar smuzaffar merged commit 1a21d33 into cms-sw:IB/CMSSW_13_0_X/master Mar 11, 2024
8 of 9 checks passed
@forthommel forthommel deleted the cepgen-13_0_X branch March 11, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants