Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13_0_X] CepGen generator interface #44270

Merged
merged 1 commit into from
Mar 7, 2024
Merged

[13_0_X] CepGen generator interface #44270

merged 1 commit into from
Mar 7, 2024

Conversation

forthommel
Copy link
Contributor

PR description:

This PR introduces an interface to the CepGen central exclusive processes event generator described in Comput. Phys. Commun. 271 (2022), and introduced at a CMS-PH generator meeting last October.

It is shipped with generator fragments for a LPAIR and a PPtoFF single-dissociative generation. The earlier also demonstrates the interfacing of Pythia 6 for the fragmentation of dissociative beam remnants into a hadronic shower.

Requires CepGen v1.2.0+, added to cmsdist for 13_0_X releases in cms-sw/cmsdist#9041.

PR validation:

Shipped in generator fragments seem to be producing something consistent.

cmsDriver.py Configuration/Generator/python/CepGen_pptoff_GamGamToLL_singlediss_13TeV_cfi.py --conditions auto:run2_mc -s GEN --datatier GEN -n 10 --eventcontent RAWSIM --no_exec
cmsDriver.py Configuration/Generator/python/CepGen_LPAIR_GamGamToLL_singlediss_13TeV_cfi.py --conditions auto:run2_mc -s GEN --datatier GEN -n 10 --eventcontent RAWSIM --no_exec

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44072 for Summer23 MC campaigns

@forthommel
Interface to the CepGen event generator
69e7cae 
Along with the "generator filter" implementation linking everything together, this contains
generator fragments for a LPAIR and a PPtoFF single-dissociative generation.
The PPtoFF fragment also demonstrates the capability to use Pythia 6 for the fragmentation
of the dissociative beam remnants.

Requires CepGen v1.2.0 at least.
@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Feb 29, 2024
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @forthommel for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/Generator (generators)
  • GeneratorInterface/CepGenInterface (generators)

@menglu21, @cmsbuild, @SiewYan, @mkirsano, @GurpreetSinghChahal, @bbilin, @alberto-sanchez can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald, @mkirsano, @fabiocos, @alberto-sanchez this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 29, 2024 •
edited
Loading

cms-bot internal usage

@bbilin
Copy link
Contributor

bbilin commented Feb 29, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2adfd4/37819/summary.html
COMMIT: 69e7cae
CMSSW: CMSSW_13_0_X_2024-02-25-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44270/37819/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Package GeneratorInterface/CepGenInterface built
Entering library rule at src/GeneratorInterface/CepGenInterface/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2024-02-25-0000/src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc
>> Building edm plugin tmp/el8_amd64_gcc11/src/GeneratorInterface/CepGenInterface/plugins/GeneratorInterfaceCepGenGenerator/libGeneratorInterfaceCepGenGenerator.so
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02826/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/../lib/gcc/x86_64-redhat-linux-gnu/11.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lGeneratorInterfaceCepGenInterface
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc11/src/GeneratorInterface/CepGenInterface/plugins/GeneratorInterfaceCepGenGenerator/libGeneratorInterfaceCepGenGenerator.so] Error 1
Leaving library rule at src/GeneratorInterface/CepGenInterface/plugins
Entering library rule at GeneratorInterface/CepGenInterface
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2024-02-25-0000/src/GeneratorInterface/CepGenInterface/src/CepGenEventGenerator.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2024-02-25-0000/src/GeneratorInterface/CepGenInterface/src/CepGenGeneratorFilter.cc

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'


>> Local Products Rules ..... started
>> Local Products Rules ..... done
>> Creating project symlinks
>> Entering Package GeneratorInterface/CepGenInterface
>> Compile sequence completed for CMSSW CMSSW_13_0_X_2024-02-25-0000
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2024-02-25-0000/tmp/el8_amd64_gcc11/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package GeneratorInterface/CepGenInterface
Entering library rule at src/GeneratorInterface/CepGenInterface/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2024-02-25-0000/src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc

@forthommel
Copy link
Contributor Author

@bbilin, probably you meant @cmsbuild please test with cms-sw/cmsdist#9041 :-)

@iarspider
Copy link
Contributor

please test with cms-sw/cmsdist#9041

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2adfd4/37890/summary.html
COMMIT: 69e7cae
CMSSW: CMSSW_13_0_X_2024-03-03-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44270/37890/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test PhysicsToolsNanoAODToolsTestDriver had ERRORS

Comparison Summary

Summary:

  • You potentially added 230 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283620
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3283595
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@forthommel
Copy link
Contributor Author

Always the same unit test failure :-)

@iarspider
Copy link
Contributor

---> test PhysicsToolsNanoAODToolsTestDriver had ERRORS

Known issue: #44293

@forthommel forthommel mentioned this pull request Mar 5, 2024
Merged
@bbilin
Copy link
Contributor

bbilin commented Mar 5, 2024

+1

Local tests successful.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9041

@forthommel
Copy link
Contributor Author

@antoniovilela, @rappoccio, @sextonkennedy, please let me know if there is anything I can clarify on this backport PR!

@rappoccio
Copy link
Contributor

+1

@rappoccio
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 7f848ea into cms-sw:CMSSW_13_0_X Mar 7, 2024
9 of 10 checks passed
@forthommel forthommel deleted the cepgen_integration-13_0_X branch March 7, 2024 15:25
@forthommel
Copy link
Contributor Author

Many thanks, @rappoccio ! However do not forget that this will not build without cms-sw/cmsdist#9041

@forthommel forthommel mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fully-signed generators-approved orp-approved requires-external tests-rejected
Projects
None yet
Milestone
CMSSW_13_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@forthommel @cmsbuild @bbilin @iarspider @rappoccio