Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cepgen: add dependency on bzlib2 #8329

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

iarspider
Copy link
Contributor

This fixes the following error:

02:37:07 RpmInstallFailed: Failed to install package cepgen. Reason:
02:37:07 error: Failed dependencies:
02:37:07 	libbz2.so.1()(64bit) is needed by external+cepgen+1.1.0-f16bfcee94054c9329075aefb119b6cc-1-1.aarch64
02:37:07 

The library is used to handle compressed HepMC3 files.

@forthommel

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_1_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test for el9_aarch64_gcc11

@cmsbuild
Copy link
Contributor

Pull request #8329 was updated.

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

please test for el9_aarch64_gcc11

@smuzaffar
Copy link
Contributor

@iarspider , I see the following in build log

-- Found ZLIB: /usr/lib64/libz.so (found version "1.2.11") 
-- Could NOT find LibLZMA (missing: LIBLZMA_LIBRARY LIBLZMA_INCLUDE_DIR LIBLZMA_HAS_AUTO_DECODER LIBLZMA_HAS_EASY_ENCODER LIBLZMA_HAS_LZMA_PRESET) 
-- Found BZip2: /usr/lib64/libbz2.so (found version "1.0.6") 
-- Looking for BZ2_bzCompressInit
-- Looking for BZ2_bzCompressInit - found

looks like cmake needs to be properly configured to find bz2lib and zlib. Can you please add

-DCMAKE_PREFIX_PATH="${<TOOL>_ROOT}...for the tools cepgen depend it"

I would suggest to try to build it locally and see if that is enough for cepgen to use externals for cms area

@iarspider
Copy link
Contributor Author

@smuzaffar ok

@iarspider
Copy link
Contributor Author

please abort

@cmsbuild
Copy link
Contributor

Pull request #8329 was updated.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df839f/30807/summary.html
COMMIT: 392e50c
CMSSW: CMSSW_13_1_X_2023-02-21-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8329/30807/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 32 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3528709
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3528681
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals
build log looks good now

-- Found ZLIB: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/zlib/1.2.11-3dfb2715f3608466b74431b80eb9d788/lib/libz.so (found version "1.2.8") 
-- Looking for lzma_auto_decoder in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/xz/5.2.5-83d0a00b575efd1701e07bedf7977343/lib/liblzma.so
-- Looking for lzma_auto_decoder in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/xz/5.2.5-83d0a00b575efd1701e07bedf7977343/lib/liblzma.so - found
-- Looking for lzma_easy_encoder in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/xz/5.2.5-83d0a00b575efd1701e07bedf7977343/lib/liblzma.so
-- Looking for lzma_easy_encoder in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/xz/5.2.5-83d0a00b575efd1701e07bedf7977343/lib/liblzma.so - found
-- Looking for lzma_lzma_preset in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/xz/5.2.5-83d0a00b575efd1701e07bedf7977343/lib/liblzma.so
-- Looking for lzma_lzma_preset in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/xz/5.2.5-83d0a00b575efd1701e07bedf7977343/lib/liblzma.so - found
-- Found LibLZMA: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/xz/5.2.5-83d0a00b575efd1701e07bedf7977343/lib/liblzma.so (found version "5.2.5") 
-- Found BZip2: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/bz2lib/1.0.6-2c1f18484cb66c30aba7929f2be5e7d4/lib/libbz2.so (found version "1.0.6") 
-- Looking for BZ2_bzCompressInit
-- Looking for BZ2_bzCompressInit - found

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants