Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add condition in vecgeom for powerpc #5478

Merged
merged 2 commits into from
Jan 25, 2020
Merged

Add condition in vecgeom for powerpc #5478

merged 2 commits into from
Jan 25, 2020

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Jan 20, 2020 •
edited
Loading

Add flag -mlong-double-64 if builds on powerpc

@mrodozov
Add condition in vecgeom for powerpc
d0a1596 
Add flag -mlong-double-64 if runs on powerpc
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #5478 was updated.

@mrodozov mrodozov mentioned this pull request Jan 21, 2020
Closed
@cmsbuild cmsbuild mentioned this pull request Jan 21, 2020
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 21, 2020 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-externals/onnxruntime#4,#5477
Test Parameters:

@mrodozov
Copy link
Contributor Author

the PR is aiming at this issue:
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_ppc64le_gcc820/CMSSW_11_1_X_2020-01-19-2300/BigProducts/Simulation

@cmsbuild
Copy link
Contributor

-1

Tested at: 9fdd27d

CMSSW: CMSSW_11_1_X_2020-01-20-2300
SCRAM_ARCH: slc7_ppc64le_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70bf23/4296/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test test_PrepareInputDb had ERRORS
---> test test_MpsWorkFlow had ERRORS
---> test testSerializationCommon had ERRORS
---> test testUnits had ERRORS
---> test testDD4hepFilteredView had ERRORS
---> test DetectorDescriptionDDCMSTestDriver had ERRORS
---> test testFWCoreConcurrency had ERRORS
---> test TestFWCoreParameterSetDriver had ERRORS
---> test testONNXRuntime had ERRORS
---> test testNumba had ERRORS
---> test testRootpy had ERRORS
---> test test_pycurl had ERRORS
---> test GeometryDTGeometryBuilderTestDriver had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 21, 2020 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-externals/onnxruntime#4,#5477
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 9fdd27d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70bf23/4299/summary.html
CMSSW: CMSSW_11_1_X_2020-01-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70bf23/4299/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/1.0_ProdMinBias+ProdMinBias+DIGIPROD1+RECOPROD1
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/2.0_ProdTTbar+ProdTTbar+DIGIPROD1+RECOPROD1
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/3.0_ProdQCD_Pt_3000_3500+ProdQCD_Pt_3000_3500+DIGIPROD1+RECOPROD1
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/4.23_ValSkim2011A+ValSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/4.24_WMuSkim2011A+WMuSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/4.25_WElSkim2011A+WElSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697090
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696743
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70bf23/4296/summary.html

The workflows 1001.0, 1000.0, 140.53, 136.85, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins_b/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/1.0_ProdMinBias+ProdMinBias+DIGIPROD1+RECOPROD1
  • /build/cmsbld/jenkins_b/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/2.0_ProdTTbar+ProdTTbar+DIGIPROD1+RECOPROD1
  • /build/cmsbld/jenkins_b/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/3.0_ProdQCD_Pt_3000_3500+ProdQCD_Pt_3000_3500+DIGIPROD1+RECOPROD1
  • /build/cmsbld/jenkins_b/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/4.23_ValSkim2011A+ValSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT
  • /build/cmsbld/jenkins_b/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/4.24_WMuSkim2011A+WMuSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT
  • /build/cmsbld/jenkins_b/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/4.25_WElSkim2011A+WElSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 49931 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697090
  • DQMHistoTests: Total failures: 129526
  • DQMHistoTests: Total nulls: 18
  • DQMHistoTests: Total successes: 2567200
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -6517.129 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -259.963 KiB DQM/TimerService
  • DQMHistoSizes: changed ( 10224.0 ): 0.129 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 1306.0,... ): -204.107 KiB DQM/TimerService
  • DQMHistoSizes: changed ( 1325.7,... ): -204.104 KiB DQM/TimerService
  • DQMHistoSizes: changed ( 136.731,... ): -204.115 KiB DQM/TimerService
  • DQMHistoSizes: changed ( 136.731 ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 136.85 ): 0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): 0.102 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.410 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -0.987 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): ...
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 23, 2020 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4338/console Started: 2020/01/23 23:10

@cmsbuild
Copy link
Contributor

+1
Tested at: 9fdd27d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db0818/4338/summary.html
CMSSW: CMSSW_11_1_X_2020-01-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db0818/4338/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697090
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696743
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 70f4340 into IB/CMSSW_11_1_X/master Jan 25, 2020
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the ppc-condition-vecgeom branch January 25, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available externals-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrodozov @cmsbuild @smuzaffar