Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Remove arch condition #5477

Closed
wants to merge 1 commit into from
Closed

[ONNX] Remove arch condition #5477

wants to merge 1 commit into from

Conversation

mrodozov
Copy link
Contributor

Remove the powerpc condition for onnxruntime externals to test it

@mrodozov
[ONNX] Remove OS condition
0ab0e7f 
Remove the powerpc condition for onnxruntime externals to test it
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_1_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov mrodozov mentioned this pull request Jan 20, 2020
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 20, 2020 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-externals/onnxruntime#4
Test Parameters:

@cmsbuild
Copy link
Contributor

-1

Tested at: 0ab0e7f

CMSSW: CMSSW_11_1_X_2020-01-19-2300
SCRAM_ARCH: slc7_ppc64le_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-645a76/4287/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/nweek-02612/slc7_ppc64le_gcc820/external/gcc/8.3.0/bin/../lib/gcc/powerpc64le-unknown-linux-gnu/8.3.1/../../../../powerpc64le-unknown-linux-gnu/bin/ld: failed to merge target specific data of file /build/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-01-19-2300/external/slc7_ppc64le_gcc820/lib/libvecgeom.a(UnplacedSphere.cpp.o)
/cvmfs/cms-ib.cern.ch/nweek-02612/slc7_ppc64le_gcc820/external/gcc/8.3.0/bin/../lib/gcc/powerpc64le-unknown-linux-gnu/8.3.1/../../../../powerpc64le-unknown-linux-gnu/bin/ld: objs/slc7_ppc64le_gcc820/SimG4CMSCaloPlugins.obj uses 64-bit long double, /build/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-01-19-2300/external/slc7_ppc64le_gcc820/lib/libvecgeom.a(UnplacedAssembly.cpp.o) uses 128-bit long double
/cvmfs/cms-ib.cern.ch/nweek-02612/slc7_ppc64le_gcc820/external/gcc/8.3.0/bin/../lib/gcc/powerpc64le-unknown-linux-gnu/8.3.1/../../../../powerpc64le-unknown-linux-gnu/bin/ld: failed to merge target specific data of file /build/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-01-19-2300/external/slc7_ppc64le_gcc820/lib/libvecgeom.a(UnplacedAssembly.cpp.o)
/cvmfs/cms-ib.cern.ch/nweek-02612/slc7_ppc64le_gcc820/external/gcc/8.3.0/bin/../lib/gcc/powerpc64le-unknown-linux-gnu/8.3.1/../../../../powerpc64le-unknown-linux-gnu/bin/ld: objs/slc7_ppc64le_gcc820/SimG4CMSCaloPlugins.obj uses 64-bit long double, /build/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-01-19-2300/external/slc7_ppc64le_gcc820/lib/libvecgeom.a(PlacedBooleanVolume.cpp.o) uses 128-bit long double
/cvmfs/cms-ib.cern.ch/nweek-02612/slc7_ppc64le_gcc820/external/gcc/8.3.0/bin/../lib/gcc/powerpc64le-unknown-linux-gnu/8.3.1/../../../../powerpc64le-unknown-linux-gnu/bin/ld: failed to merge target specific data of file /build/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-01-19-2300/external/slc7_ppc64le_gcc820/lib/libvecgeom.a(PlacedBooleanVolume.cpp.o)
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_ppc64le_gcc820/src/BigProducts/Simulation/pluginSimulation.so] Error 1
>> Leaving Package src/BigProducts/Simulation
>> Package src/BigProducts/Simulation built
>> Leaving Package src/BigProducts/Simulation
>> Package src/BigProducts/Simulation built

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@mrodozov mrodozov changed the title [ONNX] Remove OS condition [ONNX] Remove arch condition Jan 20, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 21, 2020 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-externals/onnxruntime#4,#5478
Test Parameters:

@cmsbuild cmsbuild mentioned this pull request Jan 21, 2020
Merged
@cmsbuild
Copy link
Contributor

-1

Tested at: 0ab0e7f

CMSSW: CMSSW_11_1_X_2020-01-20-2300
SCRAM_ARCH: slc7_ppc64le_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70bf23/4296/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test test_PrepareInputDb had ERRORS
---> test test_MpsWorkFlow had ERRORS
---> test testSerializationCommon had ERRORS
---> test testUnits had ERRORS
---> test testDD4hepFilteredView had ERRORS
---> test DetectorDescriptionDDCMSTestDriver had ERRORS
---> test testFWCoreConcurrency had ERRORS
---> test TestFWCoreParameterSetDriver had ERRORS
---> test testONNXRuntime had ERRORS
---> test testNumba had ERRORS
---> test testRootpy had ERRORS
---> test test_pycurl had ERRORS
---> test GeometryDTGeometryBuilderTestDriver had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 21, 2020 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-externals/onnxruntime#4,#5478
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 0ab0e7f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70bf23/4299/summary.html
CMSSW: CMSSW_11_1_X_2020-01-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70bf23/4299/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/1.0_ProdMinBias+ProdMinBias+DIGIPROD1+RECOPROD1
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/2.0_ProdTTbar+ProdTTbar+DIGIPROD1+RECOPROD1
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/3.0_ProdQCD_Pt_3000_3500+ProdQCD_Pt_3000_3500+DIGIPROD1+RECOPROD1
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/4.23_ValSkim2011A+ValSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/4.24_WMuSkim2011A+WMuSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/4.25_WElSkim2011A+WElSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697090
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696743
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70bf23/4296/summary.html

The workflows 1001.0, 1000.0, 140.53, 136.85, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins_b/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/1.0_ProdMinBias+ProdMinBias+DIGIPROD1+RECOPROD1
  • /build/cmsbld/jenkins_b/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/2.0_ProdTTbar+ProdTTbar+DIGIPROD1+RECOPROD1
  • /build/cmsbld/jenkins_b/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/3.0_ProdQCD_Pt_3000_3500+ProdQCD_Pt_3000_3500+DIGIPROD1+RECOPROD1
  • /build/cmsbld/jenkins_b/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/4.23_ValSkim2011A+ValSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT
  • /build/cmsbld/jenkins_b/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/4.24_WMuSkim2011A+WMuSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT
  • /build/cmsbld/jenkins_b/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-70bf23/4.25_WElSkim2011A+WElSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 49931 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697090
  • DQMHistoTests: Total failures: 129526
  • DQMHistoTests: Total nulls: 18
  • DQMHistoTests: Total successes: 2567200
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -6517.129 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -259.963 KiB DQM/TimerService
  • DQMHistoSizes: changed ( 10224.0 ): 0.129 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 1306.0,... ): -204.107 KiB DQM/TimerService
  • DQMHistoSizes: changed ( 1325.7,... ): -204.104 KiB DQM/TimerService
  • DQMHistoSizes: changed ( 136.731,... ): -204.115 KiB DQM/TimerService
  • DQMHistoSizes: changed ( 136.731 ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 136.85 ): 0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): 0.102 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.410 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -0.987 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): ...
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@mrodozov
Copy link
Contributor Author

closing this, we can reopen in if necessary.

@mrodozov mrodozov closed this Feb 12, 2020
@smuzaffar smuzaffar deleted the remove-powerpc-condition-onnx branch February 13, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available externals-pending orp-pending pending-signatures requires-external tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrodozov @cmsbuild