Get it to work on powerpc #4
Conversation
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: e750412
I found compilation error when building: -- Performing Test AVX512BW_COMPILES -- Performing Test AVX512BW_COMPILES - Success -- Configuring incomplete, errors occurred! See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/onnxruntime/1.0.0-90a298/build/CMakeFiles/CMakeOutput.log". See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/onnxruntime/1.0.0-90a298/build/CMakeFiles/CMakeError.log". error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.2thM47 (%build) RPM build errors: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.2thM47 (%build) You can see the results of the tests here: |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: e750412
I found compilation error when building: -- Performing Test AVX512BW_COMPILES -- Performing Test AVX512BW_COMPILES - Success -- Configuring incomplete, errors occurred! See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/onnxruntime/1.0.0-90a298/build/CMakeFiles/CMakeOutput.log". See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/onnxruntime/1.0.0-90a298/build/CMakeFiles/CMakeError.log". error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.1hAJG5 (%build) RPM build errors: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.1hAJG5 (%build) You can see the results of the tests here: |
|
please test with cms-sw/cms-bot#1249 |
|
The tests are being triggered in jenkins. |
|
The tests are being triggered in jenkins.
|
|
-1 Tested at: e750412 CMSSW: CMSSW_11_1_X_2020-01-20-2300 I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test test_PrepareInputDb had ERRORS |
|
Comparison job queued. |
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
Comparison is ready The workflows 1001.0, 1000.0, 140.53, 136.85, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
### Description
Release OrtEnv before main function returns. Before this change, OrtEnv
is deleted when C/C++ runtime destructs all global variables in ONNX
Runtime's core framework.
The callstack is like this:
```
* frame #0: 0x00007fffee39f5a6 libonnxruntime.so.1.16.0`onnxruntime::Environment::~Environment(this=0x00007fffee39fbf2) at environment.h:20:7
frame cms-externals#1: 0x00007fffee39f614 libonnxruntime.so.1.16.0`std::default_delete<onnxruntime::Environment>::operator()(this=0x00007ffff4c30e50, __ptr=0x0000000005404b00) const at unique_ptr.h:85:2
frame cms-externals#2: 0x00007fffee39edca libonnxruntime.so.1.16.0`std::unique_ptr<onnxruntime::Environment, std::default_delete<onnxruntime::Environment>>::~unique_ptr(this=0x5404b00) at unique_ptr.h:361:17
frame cms-externals#3: 0x00007fffee39e2ab libonnxruntime.so.1.16.0`OrtEnv::~OrtEnv(this=0x00007ffff4c30e50) at ort_env.cc:43:1
frame cms-externals#4: 0x00007fffee39fa96 libonnxruntime.so.1.16.0`std::default_delete<OrtEnv>::operator()(this=0x00007fffefff8f78, __ptr=0x00007ffff4c30e50) const at unique_ptr.h:85:2
frame cms-externals#5: 0x00007fffee39f394 libonnxruntime.so.1.16.0`std::unique_ptr<OrtEnv, std::default_delete<OrtEnv>>::~unique_ptr(this=0x7ffff4c30e50) at unique_ptr.h:361:17
frame cms-externals#6: 0x00007ffff78574b5 libc.so.6`__run_exit_handlers + 261
frame cms-externals#7: 0x00007ffff7857630 libc.so.6`exit + 32
frame cms-externals#8: 0x00007ffff783feb7 libc.so.6`__libc_start_call_main + 135
frame cms-externals#9: 0x00007ffff783ff60 libc.so.6`__libc_start_main@@GLIBC_2.34 + 128
frame cms-externals#10: 0x0000000000abbdee node`_start + 46
```
After this change, OrtEnv will be deleted before the main function
returns and nodejs is still alive.
Changes to make it work on ppc. If the results from comparison are reasonable this additions can (and probably should) be trimmed as they use tiny part of the entire NEON _2_SSE 17k lines functionality. This PR is to make sure it doesn't interfere with the base build (i.e. wont brake the external on Intel arch)