Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CRAB] Trigger unittest in case of CRAB updates #1881

Merged
merged 10 commits into from
Nov 17, 2022
Merged

[CRAB] Trigger unittest in case of CRAB updates #1881

merged 10 commits into from
Nov 17, 2022

Conversation

aandvalenzuela
Copy link
Contributor

Follow-up PR for #1874

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@aandvalenzuela
Copy link
Contributor Author

please test with cms-sw/cmsdist#8168

@cmsbuild
Copy link
Contributor

Pull request #1881 was updated.

@aandvalenzuela
Force CRAB failure and minor fixes
bdb8fe2 
Force CRAB failure

Fix typo

Fix typo

Fix path to cms-bot

Fix typo

Fix directories

Use existing cms-bot

Fix filename

Declare message
@cmsbuild
Copy link
Contributor

Pull request #1881 was updated.

@aandvalenzuela
Copy link
Contributor Author

please test with cms-sw/cmsdist#8168

  • [TESTING PURPOSES] We expect this to fail in CRAB dev

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-016b49/28964/summary.html
COMMIT: bdb8fe2
CMSSW: CMSSW_12_6_X_2022-11-10-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/1881/28964/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416447
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416416
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aandvalenzuela
Copy link
Contributor Author

@smuzaffar do we need to test it with another cmsbot PR or cmsdist instead?

@smuzaffar
Copy link
Contributor

@smuzaffar do we need to test it with another cmsbot PR or cmsdist instead?

PR itself look good but the crab test part still need fixes. e.g. I do not see an explicit cmssw dev area creation in ib-run-pr-crab script.

@cmsbuild
Copy link
Contributor

Pull request #1881 was updated.

@aandvalenzuela
Copy link
Contributor Author

@smuzaffar Is there any difference on creating the cmssw dev area before the crab submit command or after it?

smuzaffar
smuzaffar reviewed Nov 16, 2022
View reviewed changes
crab/ib-run-pr-crab.sh Outdated Show resolved Hide resolved
smuzaffar
smuzaffar reviewed Nov 16, 2022
View reviewed changes
crab/ib-run-pr-crab.sh Outdated Show resolved Hide resolved
smuzaffar
smuzaffar reviewed Nov 16, 2022
View reviewed changes
crab/ib-run-pr-crab.sh Outdated Show resolved Hide resolved
smuzaffar
smuzaffar reviewed Nov 16, 2022
View reviewed changes
crab/ib-run-pr-crab.sh Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

Pull request #1881 was updated.

@cmsbuild
Copy link
Contributor

Pull request #1881 was updated.

@cmsbuild
Copy link
Contributor

Pull request #1881 was updated.

@aandvalenzuela
Copy link
Contributor Author

please test with cms-sw/cmsdist#8166

@aandvalenzuela
Copy link
Contributor Author

@smuzaffar CRAB already finished

@aandvalenzuela aandvalenzuela merged commit 974ada9 into cms-sw:master Nov 17, 2022
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-016b49/29074/summary.html
COMMIT: 7aabcb7
CMSSW: CMSSW_12_6_X_2022-11-16-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/1881/29074/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-016b49/29074/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-016b49/29074/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 15 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3417074
  • DQMHistoTests: Total failures: 79
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416973
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4.224 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.530 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 0.348 KiB Physics/NanoAODDQM
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smuzaffar smuzaffar smuzaffar left review comments

Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures requires-external tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aandvalenzuela @cmsbuild @smuzaffar