Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRAB] Check for updates in crab spec files to trigger unit test #1874

Closed
wants to merge 77 commits into from

Conversation

aandvalenzuela
Copy link
Contributor

This check allows us to test CRAB updates as cms-sw/cmsdist#8159.

Check for crab updates

Fix typo

Fix typo

Fix BASE_REPO

Not modify helper func

pushd to correct directory

Check git diff if externals rebuilt

Paths

Fix paths

Check if cmsdist exists

Check for crab updates

Remove debug prints

Create property file

Reorder writing in crab.prop

Store all required parameters in prp file

Store all required parameters

Fix typo

Clean scripts

Fix
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2022

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2022

Pull request #1874 was updated.

@aandvalenzuela aandvalenzuela marked this pull request as draft November 3, 2022 09:52
@aandvalenzuela
Copy link
Contributor Author

I will re-open it once it is done to avoid notifications

@aandvalenzuela aandvalenzuela reopened this Nov 3, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2022

Pull request #1874 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2022

Pull request #1874 was updated.

@aandvalenzuela aandvalenzuela marked this pull request as ready for review November 3, 2022 14:45
@aandvalenzuela
Copy link
Contributor Author

@smuzaffar I think we can merge the test and I will open a follow-up PR for the reporting to git, so that the test is available as soon as possible.

@aandvalenzuela
Copy link
Contributor Author

Thanks @smuzaffar! Applying changes and testing

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2022

Pull request #1874 was updated.

@aandvalenzuela
Copy link
Contributor Author

please test with cms-sw/cmsdist#8168

@aandvalenzuela
Copy link
Contributor Author

please test with cms-sw/cmsdist#8168

@cmsbuild
Copy link
Contributor

Pull request #1874 was updated.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14970a/28940/summary.html
COMMIT: b7c2c1a
CMSSW: CMSSW_12_6_X_2022-11-09-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/1874/28940/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416447
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416419
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14970a/28940/summary.html
COMMIT: b7c2c1a
CMSSW: CMSSW_12_6_X_2022-11-09-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/1874/28940/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416447
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416419
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14970a/28940/summary.html
COMMIT: b7c2c1a
CMSSW: CMSSW_12_6_X_2022-11-09-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/1874/28940/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416447
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416419
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants