Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmsmon-tools.spec #8182

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Update cmsmon-tools.spec #8182

merged 3 commits into from
Nov 16, 2022

Conversation

iarspider
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_6_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #8182 was updated.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8182 was updated.

@iarspider
Copy link
Contributor Author

@smuzaffar I'm not sure I wrote the %setup commands correctly - but at least it works. Also, should I uncomment and change REVISION

#CMSDIST_FILE_REVISION=1
?

@smuzaffar
Copy link
Contributor

@iarspider , #CMSDIST_FILE_REVISION=1 should only be updated if the script's contents itself are updated and it should remain commented as common_revision_script search for this comment. So no need to uncomment/update CMSDIST_FILE_REVISION

@iarspider
Copy link
Contributor Author

@smuzaffar thanks!

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac0aa0/29039/summary.html
COMMIT: 4cce242
CMSSW: CMSSW_12_6_X_2022-11-15-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8182/29039/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3417074
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3417046
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_6_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants