Adapt failed_jobs to run frequently #328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathap
force-pushed
the
adapt-failed-jobs-to-run-frequently
branch
from
ee98ac3 to
c2126dd
Compare
kathap
force-pushed
the
adapt-failed-jobs-to-run-frequently
branch
from
96a5c65 to
6302724
Compare
philippthun
reviewed
Jul 28, 2023
jobs/cloud_controller_clock/spec
Outdated
| @@ -114,6 +114,10 @@ properties: | |||
| description: "The age at which completed tasks are pruned from the Cloud Controller database" | |||
| default: 31 | |||
|
|
|||
| cc.failed_jobs.max_number_of_failed_delayed_jobs: | |||
| description: "Maximum number of failed jobs that should stay in cloud controller database before being cleaned up" | |||
| default: 100000 | |||
There was a problem hiding this comment.
That's a rather low default value, or?
There was a problem hiding this comment.
There is no default value any more
kathap
force-pushed
the
adapt-failed-jobs-to-run-frequently
branch
from
f9e307d to
3a94697
Compare
kathap
force-pushed
the
adapt-failed-jobs-to-run-frequently
branch
from
3a94697 to
cce6d25
Compare
5 tasks
|
Closed in favor of #332 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far failed_jobs was running once per day. We want to let it run more often, therefore we need to add the necessary params.
Failed_jobs is changed to also cleanup failed entries from the delayed_jobs table that exceeds a defined maximum number of entries in order to prevent overload of the db. The job should run more often than once per day to ensure db is not overloaded.
Related to cloudfoundry/cloud_controller_ng#3346
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite