Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt failed_jobs to run frequently #328

Closed
wants to merge 5 commits into from
Closed

Adapt failed_jobs to run frequently #328

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6302724
Adapt failed_jobs to run frequently
kathap Jul 17, 2023
8f9baa2
adapt to optional cc.failed_jobs parameter and add unit test
kathap Jul 28, 2023
cce6d25
Merge branch 'develop' into adapt-failed-jobs-to-run-frequently
kathap Jul 28, 2023
92c8382
add test for cloud_controller_clock failed_jobs optional parameter
kathap Jul 31, 2023
552b220
clean up
kathap Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions jobs/cloud_controller_clock/spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,10 @@ properties:
description: "The age at which completed tasks are pruned from the Cloud Controller database"
default: 31

cc.failed_jobs.max_number_of_failed_delayed_jobs:
description: "Maximum number of failed jobs that should stay in cloud controller database before being cleaned up"
default: 100000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a rather low default value, or?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no default value any more


cc.pending_droplets.frequency_in_seconds:
description: "How often the pending droplets cleanup job runs"
default: 300
Expand All @@ -123,6 +127,9 @@ properties:
cc.diego_sync.frequency_in_seconds:
description: "How often to synchronize CC's database with Diego's"
default: 30
cc.failed_jobs.frequency_in_seconds:
description: "How often the failed_jobs cleanup job runs"
default: 144000 # 4 hours

cc.external_protocol:
default: "https"
Expand Down
2 changes: 2 additions & 0 deletions jobs/cloud_controller_clock/templates/cloud_controller_ng.yml.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ audit_events:

failed_jobs:
cutoff_age_in_days: <%= p("cc.failed_jobs.cutoff_age_in_days") %>
max_number_of_failed_delayed_jobs: <%= p("cc.failed_jobs.max_number_of_failed_delayed_jobs") %>
frequency_in_seconds: <%= p("cc.failed_jobs.frequency_in_seconds") %>

completed_tasks:
cutoff_age_in_days: <%= p("cc.completed_tasks.cutoff_age_in_days") %>
Expand Down