The failed_jobs cleanup job should run more often than once per day #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ensure db is not overloaded.
kathap
force-pushed
the
adapt-failed-jobs-to-run-frequently-add-new-optional-parameter
branch
from
7d8cd41 to
13ba8d5
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far failed_jobs was running once per day. We want to let it run more often, therefore we need to add the necessary params.
Failed_jobs is changed to also cleanup failed entries from the delayed_jobs table that exceeds a defined maximum number of entries in order to prevent overload of the db. The new parameter max_number_of_failed_delayed_jobs is optional.
With this change the job should runs more often than once per day (default is every 4h) to ensure db is not overloaded.
Links to any other associated PRs
Related to More aggressive cleanup of failed delayed jobs cloud_controller_ng#3346
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite