Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill hanging process after integration tests complete #670

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

GregBrimble
Copy link
Member

@GregBrimble GregBrimble commented Mar 22, 2022

Fixes #397 and #618

@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2022

⚠️ No Changeset found

Latest commit: 4b9c3aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2022810901/npm-package-wrangler-670

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/670/npm-package-wrangler-670

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2022810901/npm-package-wrangler-670 dev path/to/script.js

@GregBrimble GregBrimble force-pushed the 397-kill-hanging-process-after-tests-complete branch from 1a0f403 to 4b9c3aa Compare March 22, 2022 14:01
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@GregBrimble GregBrimble merged commit 4205539 into main Mar 22, 2022
@GregBrimble GregBrimble deleted the 397-kill-hanging-process-after-tests-complete branch March 22, 2022 14:10
@JacobMGEvans JacobMGEvans mentioned this pull request Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance task pages Relating to Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: tests in example-remix-app leaves a hanging esbuild process
2 participants