Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tests in example-remix-app leaves a hanging esbuild process #397

Closed
threepointone opened this issue Feb 6, 2022 · 1 comment · Fixed by #670, #678 or #679
Closed

chore: tests in example-remix-app leaves a hanging esbuild process #397

threepointone opened this issue Feb 6, 2022 · 1 comment · Fixed by #670, #678 or #679
Assignees
@GregBrimble
Labels
maintenance Maintenance task pages Relating to Pages

Comments

@threepointone
Copy link
Contributor

On my machine, running npm test occasionally leaves a hanging esbuild process (say, 1 out of 3 times). Looking closer, it appears to be coming from example-remix-app, which means running jest --forceExit isn't cleanly shutting it down. We should fix this.
image
@Electroid Electroid added the maintenance Maintenance task label Feb 6, 2022
@threepointone threepointone mentioned this issue Mar 16, 2022
Closed
@GregBrimble GregBrimble mentioned this issue Mar 16, 2022
Closed
@threepointone threepointone added bug pages Relating to Pages labels Mar 17, 2022
@GregBrimble GregBrimble mentioned this issue Mar 22, 2022
Merged
@threepointone threepointone reopened this Mar 23, 2022
@threepointone
Copy link
Contributor Author

This is still happening :(

threepointone added a commit that referenced this issue Mar 23, 2022
@threepointone
fix: cleanup after pages dev tests
a8193b8 
We weren't killing the process started by wrangler whenever its parent was killed. This fix is to listen on SIGTERM/SIGTERM and kill that process. This also lets us remove `--forceExit` from the test runner calls. I also did some minor configuration cleanups.

Fixes #397 and #618
@threepointone threepointone mentioned this issue Mar 23, 2022
Merged
threepointone added a commit that referenced this issue Mar 23, 2022
@threepointone
fix: cleanup after pages dev tests
78e11ef 
We weren't killing the process started by wrangler whenever its parent was killed. This fix is to listen on SIGINT/SIGTERM and kill that process. This also lets us remove `--forceExit` from the test runner calls. I also did some minor configuration cleanups.

Fixes #397 and #618
threepointone added a commit that referenced this issue Mar 23, 2022
@threepointone
fix: cleanup after pages dev tests
a3d2c35 
We weren't killing the process started by wrangler whenever its parent was killed. This fix is to listen on SIGINT/SIGTERM and kill that process. This also lets us remove `--forceExit` from the test runner calls. I also did some minor configuration cleanups.

Fixes #397 and #618
threepointone added a commit that referenced this issue Mar 23, 2022
@threepointone
fix: cleanup after pages dev tests
5cad8f3 
We weren't killing the process started by wrangler whenever its parent was killed. This fix is to listen on SIGINT/SIGTERM and kill that process. I also did some minor configuration cleanups.

Fixes #397 and #618
threepointone added a commit that referenced this issue Mar 23, 2022
@threepointone
fix: cleanup after pages dev tests
c2f0c6c 
We weren't killing the process started by wrangler whenever its parent was killed. This fix is to listen on SIGINT/SIGTERM and kill that process. I also did some minor configuration cleanups.

Fixes #397 and #618
threepointone added a commit that referenced this issue Mar 23, 2022
@threepointone
fix: cleanup after pages dev tests
2549799 
We weren't killing the process started by wrangler whenever its parent was killed. This fix is to listen on SIGINT/SIGTERM and kill that process. I also did some minor configuration cleanups.

Fixes #397
Fixes #618
@github-actions github-actions bot mentioned this issue Mar 23, 2022
Merged
mrbbot added a commit that referenced this issue Oct 31, 2023
@mrbbot
Pass --experimental flag to workerd (#397)
7302371 
This is required to use compatibility flags without a default-on
date, e.g. `streams_enable_constructors`
mrbbot added a commit that referenced this issue Nov 1, 2023
@mrbbot
Pass --experimental flag to workerd (#397)
871dd0f 
This is required to use compatibility flags without a default-on
date, e.g. `streams_enable_constructors`
mrbbot added a commit that referenced this issue Nov 1, 2023
@mrbbot
Pass --experimental flag to workerd (#397)
10f9a39 
This is required to use compatibility flags without a default-on
date, e.g. `streams_enable_constructors`
mrbbot added a commit that referenced this issue Nov 1, 2023
@mrbbot
Pass --experimental flag to workerd (#397)
6d759ae 
This is required to use compatibility flags without a default-on
date, e.g. `streams_enable_constructors`
This was referenced Feb 10, 2024
Open
Open
Open
Open
Open
Open
@Laurry-gee Laurry-gee mentioned this issue Feb 17, 2024
Open
This was referenced Feb 24, 2024
Open
Open
Open
Open
Open
Open
This was referenced Mar 4, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 12, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 19, 2024
Open
Open
Open
Open
Open
Open
Open
@Laurry-gee Laurry-gee mentioned this issue Mar 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GregBrimble GregBrimble

Labels
maintenance Maintenance task pages Relating to Pages
Projects
None yet
Milestone
No milestone
3 participants
@threepointone @Electroid @GregBrimble