Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remix Test #644

Closed
wants to merge 1 commit into from
Closed

Remix Test #644

wants to merge 1 commit into from

Conversation

JacobMGEvans
Copy link
Contributor

The issue with tests randomly failing in CI/CD was related Remix tests, there were some logic waiting for a fetch of a spin up of a Remix server in a spawn (ChildProcess).

  • Refactored the waitUntilReady with Promise and setTimeout resolving fetch.
  • Added a Promise flush since the function is used in a unique environment that is bleeding into Parent or Child process.
  • Additionally added a cleanup of the child process at the end of the tests, should make sure port 8789 is opened back up.

…solving fetch. Added a Promise flush since the function is used in a unique environment that is bleeding into Parent or Child process.

- Additionally added a cleanup of the child process at the end of the tests, should make sure port 8789 is opened back up.
@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2022

⚠️ No Changeset found

Latest commit: 383d6c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2006562776/npm-package-wrangler-644

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/644/npm-package-wrangler-644

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2006562776/npm-package-wrangler-644 dev path/to/script.js

@JacobMGEvans
Copy link
Contributor Author

Well... that's 30 seconds. Back to the drawing board.

@JacobMGEvans
Copy link
Contributor Author

JacobMGEvans commented Mar 18, 2022

Well... that's 30 seconds. Back to the drawing board.

Could be the async nature of spawn that is at the root of this problem. I am also open to other theories or if anyone just knows the cause.

@petebacondarwin petebacondarwin added the pages Relating to Pages label Mar 22, 2022
@JacobMGEvans
Copy link
Contributor Author

Closed due to #670

@threepointone threepointone deleted the remix-test-async branch March 23, 2022 13:42
mrbbot pushed a commit that referenced this pull request Oct 31, 2023
mrbbot pushed a commit that referenced this pull request Nov 1, 2023
mrbbot pushed a commit that referenced this pull request Nov 1, 2023
mrbbot pushed a commit that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pages Relating to Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants