Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-cloudflare): rename category #6557

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Aug 22, 2024

What this PR solves / how to test

Fixes DEVX-1381

This PR renamed the "Demo Application" category to "Application Starter" on c3.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: Renaming
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation

Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: 2729219

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@edmundhung edmundhung marked this pull request as ready for review August 22, 2024 11:37
@edmundhung edmundhung requested review from a team as code owners August 22, 2024 11:37
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507222475/npm-package-wrangler-6557

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6557/npm-package-wrangler-6557

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507222475/npm-package-wrangler-6557 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507222475/npm-package-create-cloudflare-6557 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507222475/npm-package-cloudflare-kv-asset-handler-6557
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507222475/npm-package-miniflare-6557
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507222475/npm-package-cloudflare-pages-shared-6557
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507222475/npm-package-cloudflare-vitest-pool-workers-6557
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507222475/npm-package-cloudflare-workers-editor-shared-6557
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507222475/npm-package-cloudflare-workers-shared-6557

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.1
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung merged commit 2e9aa53 into main Aug 22, 2024
23 checks passed
@edmundhung edmundhung deleted the edmundhung/c3-rename-category branch August 22, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants