Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-cloudflare): rename category #6557

Merged
merged 2 commits into from
Aug 22, 2024
Merged

fix(create-cloudflare): rename category #6557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5855351
fix(create-cloudflare): rename category
edmundhung Aug 22, 2024
2729219
add changeset
edmundhung Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/three-months-work.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"create-cloudflare": patch
---

fix: renamed the "Demo Application" category to "Application Starter"
8 changes: 4 additions & 4 deletions packages/create-cloudflare/e2e-tests/cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ describe.skipIf(frameworkToTest || isQuarantineMode())(
matcher: /What would you like to start with\?/,
input: {
type: "select",
target: "Demo application",
target: "Application Starter",
assertDescriptionText:
"Select from a range of starter applications using various Cloudflare products",
},
Expand All @@ -255,7 +255,7 @@ describe.skipIf(frameworkToTest || isQuarantineMode())(
);

expect(projectPath).toExist();
expect(output).toContain(`category Demo application`);
expect(output).toContain(`category Application Starter`);
expect(output).toContain(`type API starter (OpenAPI compliant)`);
},
);
Expand All @@ -270,7 +270,7 @@ describe.skipIf(frameworkToTest || isQuarantineMode())(
matcher: /What would you like to start with\?/,
input: {
type: "select",
target: "Demo application",
target: "Application Starter",
},
},
{
Expand Down Expand Up @@ -300,7 +300,7 @@ describe.skipIf(frameworkToTest || isQuarantineMode())(
input: {
type: "select",
target: "Framework Starter",
assertDefaultSelection: "Demo application",
assertDefaultSelection: "Application Starter",
},
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/create-cloudflare/src/helpers/args.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const cliDefinition: ArgumentsDefinition = {
values: [
{ name: "hello-world", description: "Hello World example" },
{ name: "web-framework", description: "Framework Starter" },
{ name: "demo", description: "Demo application" },
{ name: "demo", description: "Application Starter" },
{ name: "remote-template", description: "Template from a Github repo" },
],
},
Expand Down
2 changes: 1 addition & 1 deletion packages/create-cloudflare/src/templates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ export const createContext = async (
description: "Select from the most popular full-stack web frameworks",
},
{
label: "Demo application",
label: "Application Starter",
value: "demo",
description:
"Select from a range of starter applications using various Cloudflare products",
Expand Down
Loading